From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Michael Roth <michael.roth@amd.com>
Cc: devel@edk2.groups.io, Ray Ni <ray.ni@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE
Date: Thu, 16 Nov 2023 10:01:10 +0100 [thread overview]
Message-ID: <iftmx2xxkbyd76oxco2cwnozzqw5nkjqsnc2ieg22ygpem2hwr@pjaxqhffffxl> (raw)
In-Reply-To: <20231115175153.813213-1-michael.roth@amd.com>
On Wed, Nov 15, 2023 at 11:51:53AM -0600, Michael Roth wrote:
> The struct used for GHCB-based page-state change requests uses a 40-bit
> bit-field for the GFN, which is shifted by PAGE_SHIFT to generate a
> 64-bit address. However, anything beyond 40-bits simply gets shifted off
> when doing this, which will cause issues when dealing with 1TB+
> addresses. Fix this by casting the 40-bit GFN values to 64-bit ones
> prior to shifting it by PAGE_SHIFT.
>
> Fixes: ade62c18f474 ("OvmfPkg/MemEncryptSevLib: add support to validate system RAM")
> Signed-off-by: Michael Roth <michael.roth@amd.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111305): https://edk2.groups.io/g/devel/message/111305
Mute This Topic: https://groups.io/mt/102610323/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-11-16 9:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 17:51 [edk2-devel] [PATCH v2] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE Roth, Michael via groups.io
2023-11-16 9:01 ` Gerd Hoffmann [this message]
2023-11-17 9:16 ` Laszlo Ersek
2023-11-17 11:42 ` Gerd Hoffmann
2023-11-17 21:39 ` Laszlo Ersek
2023-11-20 0:26 ` [edk2-devel] 回复: [edk2-202311] " gaoliming via groups.io
2023-11-20 7:55 ` [edk2-devel] " Gerd Hoffmann
2023-11-21 17:08 ` Laszlo Ersek
2023-12-08 12:22 ` Laszlo Ersek
2023-12-08 13:29 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=iftmx2xxkbyd76oxco2cwnozzqw5nkjqsnc2ieg22ygpem2hwr@pjaxqhffffxl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox