From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 04F40941791 for ; Thu, 14 Mar 2024 11:23:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/GQKe+BwTufOBrPRw2eBAMqNkrLseLI2DI1MBbT6ed4=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1710415382; v=1; b=McA/KvqpLXsED7uuA9vVhgV0pEAn5Sn+jqwcZiPKvV4t5R4w2rqxyNGexwadF+rRLbWwyFXv gYZOO2v7yjphGEV3GLb9QJ2HVgjIh0HvybuHmDTv+aXVxgP8zpImKo8hfUO3XkzqCVOZ2bhAZ7U OCIC50nGj9TOh2WlZ/DwIItpdqKQCXCF3qIkJy2y+GdXwklEpB3fds9oLFRz7zG2l5nLfBrRfXC xsWDHBpcN2fL89M0SwG/N02x718SGlj6T8Pnv/ehHlRWz9zPjjfp7QIafNK6BOGBGjEvMmhqDE+ XDCgkI+FE6nLjQ2+Rv3ykzAm4Ii6l4fTN9w/NsSIjCgSg== X-Received: by 127.0.0.2 with SMTP id bIU0YY7687511xKjVHFYD429; Thu, 14 Mar 2024 04:23:02 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.10117.1710415381872504702 for ; Thu, 14 Mar 2024 04:23:02 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-5NLPbI6ZNE-Oo4JpdlHdSg-1; Thu, 14 Mar 2024 07:22:57 -0400 X-MC-Unique: 5NLPbI6ZNE-Oo4JpdlHdSg-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 25964185A781; Thu, 14 Mar 2024 11:22:57 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2E7817B32; Thu, 14 Mar 2024 11:22:56 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9E8051800629; Thu, 14 Mar 2024 12:22:55 +0100 (CET) Date: Thu, 14 Mar 2024 12:22:55 +0100 From: "Gerd Hoffmann" To: Chao Li Cc: devel@edk2.groups.io, Ray Ni , Rahul Kumar , Baoqi Zhang Subject: Re: [edk2-devel] [PATCH v1 06/26] UefiCpuPkg: Add CPU exception library for LoongArch Message-ID: References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093759.1253558-1-lichao@loongson.cn> MIME-Version: 1.0 In-Reply-To: <20240311093759.1253558-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 14 Mar 2024 04:23:02 -0700 Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oBaQdJJykETZoSRiKlFUgRdJx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="McA/Kvqp"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > +[Sources.LoongArch64] > + LoongArch/DxeExceptionLib.c > + LoongArch/ExceptionCommon.h > + LoongArch/ExceptionCommon.c > + LoongArch/LoongArch64/ArchExceptionHandler.c > + LoongArch/LoongArch64/ExceptionHandlerAsm.S | GCC Hmm, if all code is in an arch-specific subdirectory anyway yet another directory level for the asm code looks unnecessary to me. The code looks reasonable overall. Can't comment on loongarch specific details though. Acked-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116747): https://edk2.groups.io/g/devel/message/116747 Mute This Topic: https://groups.io/mt/104859877/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-