Re: [edk2-devel] [PATCH 08/11] OvmfPkg: switch AmdSevX64 to new shell include files

["Gerd Hoffmann" <kraxel@redhat.com>]

  Hi,

> > -!if $(TOOL_CHAIN_TAG) != "XCODE5" && $(BUILD_SHELL) == TRUE
> > -  OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf {
> > -    <PcdsFixedAtBuild>
> > -      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> > -  }
> > -!endif
> >    OvmfPkg/AmdSev/SecretDxe/SecretDxe.inf
> >    OvmfPkg/AmdSev/Grub/Grub.inf
> > -!if $(BUILD_SHELL) == TRUE
> > -  ShellPkg/Application/Shell/Shell.inf {
> > -    <LibraryClasses>
> > -      ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> > -      NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
> > -      NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
> > -      NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf
> > -      NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf
> > -      NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
> > -      NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> > -      HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> > -      PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > -      BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> >  
> > -    <PcdsFixedAtBuild>
> > -      gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF
> > -      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> > -      gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000
> > -  }
> > -!endif
> > +!include OvmfPkg/Include/Dsc/ShellComponents.dsc.inc
> >  
> >    OvmfPkg/PlatformDxe/Platform.inf
> >    OvmfPkg/AmdSevDxe/AmdSevDxe.inf {
> 
> (1) This is not an identical change. That's alright (we could say this
> is an intended benefit from factoring out the shell stuff -- it is now
> bringing forward this platform to the common state!), but it should be
> documented in the commit message.

Well, AmdSev is compiled without network support, so thanks to the
networking conditionals added easier in this patch series the it
should actually be identical.

I'll note that in the commit message.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115456): https://edk2.groups.io/g/devel/message/115456
Mute This Topic: https://groups.io/mt/103935353/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-