From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2AA3B94185D for ; Wed, 14 Feb 2024 14:24:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4sVLfG7A3SS17a+gBhE7vWd5W9L2T2JJdfKIDZtuoIM=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1707920679; v=1; b=gHqDR04mIpt0NKkdM0LPN4VejoTUJGVaV5t0wVeGGYyzxtTP1Wu+IPcLM5VgSrdicZ+G2CdM F/XRldxh3+wcckfqkpjqRxouZzQE289MoOw4z9TXpKot+EXmuznbUZ53SRHxEhIOU+8wIdMUIA+ Ys4TZYTAaK4UUJ9JxCtVFnqc= X-Received: by 127.0.0.2 with SMTP id VnH3YY7687511xdApVz6KW6K; Wed, 14 Feb 2024 06:24:39 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.42124.1707920678768099974 for ; Wed, 14 Feb 2024 06:24:38 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-C4BG1VwoNuy0zROawzuczw-1; Wed, 14 Feb 2024 09:24:33 -0500 X-MC-Unique: C4BG1VwoNuy0zROawzuczw-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 07C5085A58A; Wed, 14 Feb 2024 14:24:33 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.192]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCA98492BC6; Wed, 14 Feb 2024 14:24:32 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 894501800DCF; Wed, 14 Feb 2024 15:24:31 +0100 (CET) Date: Wed, 14 Feb 2024 15:24:31 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Jiewen Yao , Ard Biesheuvel , Michael Roth , Erdem Aktas , Min Xu , Tom Lendacky , Oliver Steffen Subject: Re: [edk2-devel] [PATCH 08/11] OvmfPkg: switch AmdSevX64 to new shell include files Message-ID: References: <20240124163802.2160303-1-kraxel@redhat.com> <20240124163802.2160303-9-kraxel@redhat.com> <5931ad5d-05e1-045c-ce2b-a352b20ebec3@redhat.com> MIME-Version: 1.0 In-Reply-To: <5931ad5d-05e1-045c-ce2b-a352b20ebec3@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: q8aOVHh0O6IdskDzG4y0SVCzx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=gHqDR04m; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > > -!if $(TOOL_CHAIN_TAG) != "XCODE5" && $(BUILD_SHELL) == TRUE > > - OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf { > > - > > - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > - } > > -!endif > > OvmfPkg/AmdSev/SecretDxe/SecretDxe.inf > > OvmfPkg/AmdSev/Grub/Grub.inf > > -!if $(BUILD_SHELL) == TRUE > > - ShellPkg/Application/Shell/Shell.inf { > > - > > - ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > > - NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf > > - NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf > > - NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf > > - NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf > > - NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf > > - NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > > - HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > - BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf > > > > - > > - gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF > > - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > - gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 > > - } > > -!endif > > +!include OvmfPkg/Include/Dsc/ShellComponents.dsc.inc > > > > OvmfPkg/PlatformDxe/Platform.inf > > OvmfPkg/AmdSevDxe/AmdSevDxe.inf { > > (1) This is not an identical change. That's alright (we could say this > is an intended benefit from factoring out the shell stuff -- it is now > bringing forward this platform to the common state!), but it should be > documented in the commit message. Well, AmdSev is compiled without network support, so thanks to the networking conditionals added easier in this patch series the it should actually be identical. I'll note that in the commit message. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115456): https://edk2.groups.io/g/devel/message/115456 Mute This Topic: https://groups.io/mt/103935353/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-