From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Abdul Lateef Attar <abdattar@amd.com>
Cc: devel@edk2.groups.io,
Abdul Lateef Attar <AbdulLateef.Attar@amd.com>,
Paul Grimes <paul.grimes@amd.com>,
Garrett Kirkendall <garrett.kirkendall@amd.com>,
Abner Chang <abner.chang@amd.com>,
Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
Rahul Kumar <rahul1.kumar@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library
Date: Tue, 11 Apr 2023 11:42:53 +0200 [thread overview]
Message-ID: <iwiosjhv5i75ahzrmp6qelp6vggcf56bl5j4rfj3mthycicbki@amujw7z55mq6> (raw)
In-Reply-To: <da1e86485bec1b60196c467772cd255814a12980.1681121324.git.abdattar@amd.com>
> Uses new SmmSmramSaveStateLib library,
> which fix the CI failure.
What is the exact failure you are seeing?
> + SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/IntelSmmSmramSaveStateLib.inf
This should be the AMD version. KVM uses the AMD smram state.
Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use
actually use the new SmmSmramSaveStateLib library, and once this
has been done it should be possible to remove
OvmfPkg/Include/Register/QemuSmramSaveStateMap.h
take care,
Gerd
next prev parent reply other threads:[~2023-04-11 9:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 11:09 [PATCH v8 0/9] Adds AmdSmmCpuFeaturesLib and SmmSmramSaveStateLib Abdul Lateef Attar
2023-04-10 11:09 ` [PATCH v8 1/9] MdePkg: Adds AMD SMRAM save state map Abdul Lateef Attar
2023-04-11 7:38 ` [edk2-devel] " Ni, Ray
2023-04-11 18:49 ` Michael D Kinney
2023-04-12 6:44 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-10 11:09 ` [PATCH v8 2/9] UefiCpuPkg: Adds SmmSmramSaveStateLib library class Abdul Lateef Attar
2023-04-11 7:50 ` [edk2-devel] " Ni, Ray
2023-04-17 8:46 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-10 11:09 ` [PATCH v8 3/9] UefiCpuPkg: Implements " Abdul Lateef Attar
2023-04-11 8:30 ` [edk2-devel] " Ni, Ray
2023-04-10 11:09 ` [PATCH v8 4/9] UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code Abdul Lateef Attar
2023-04-10 11:09 ` [PATCH v8 5/9] UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib Abdul Lateef Attar
2023-04-11 8:32 ` [edk2-devel] " Ni, Ray
2023-04-10 11:09 ` [PATCH v8 6/9] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family Abdul Lateef Attar
2023-04-11 8:35 ` [edk2-devel] " Ni, Ray
2023-04-10 11:09 ` [PATCH v8 7/9] UefiCpuPkg: Implements SmmSmramSaveStateLib for Intel Abdul Lateef Attar
2023-04-11 8:54 ` [edk2-devel] " Ni, Ray
2023-04-10 11:09 ` [PATCH v8 8/9] UefiCpuPkg: Uses SmmSmramSaveStateLib library Abdul Lateef Attar
2023-04-10 11:48 ` [edk2-devel] " Chang, Abner
2023-04-11 9:00 ` Ni, Ray
2023-04-10 11:09 ` [PATCH v8 9/9] OvmfPkg: " Abdul Lateef Attar
2023-04-11 9:42 ` Gerd Hoffmann [this message]
2023-04-11 10:09 ` [edk2-devel] " Ni, Ray
2023-04-11 10:48 ` Gerd Hoffmann
2023-04-11 11:17 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-11 12:49 ` Ni, Ray
2023-04-18 5:22 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-18 5:38 ` Ni, Ray
2023-04-18 6:42 ` Gerd Hoffmann
2023-04-11 11:12 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-10 16:29 ` [PATCH v8 0/9] Adds AmdSmmCpuFeaturesLib and SmmSmramSaveStateLib Michael D Kinney
2023-04-11 1:07 ` Chang, Abner
2023-04-11 4:16 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-11 18:48 ` Michael D Kinney
2023-04-12 2:21 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-11 18:45 ` [edk2-devel] " Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=iwiosjhv5i75ahzrmp6qelp6vggcf56bl5j4rfj3mthycicbki@amujw7z55mq6 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox