From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.9685.1681206181326009000
 for <devel@edk2.groups.io>;
 Tue, 11 Apr 2023 02:43:01 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=E4d1XUdU;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1681206180;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=4+X+dtpGd8ieL6/NcyEx/5Ca6qqmvFCUiM1kfhAzeUA=;
	b=E4d1XUdUGN/hI00ZADjqE+Xfo3wrI06Gr/t6l9jj6RmYQOUmhutGexxX/oIt+uNC8OJYxH
	irYqhjlUWp7AWB/y1XhzyaO6aT7cfmNq/zsozEhlc0pZCtHwU2FPT81QS+gS/3SNmsH5RZ
	JK8yqDErtb6iYQV/3MAV9ugFG2XIQ5U=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-210-xhBo02srOdWHTMPVaHg5Dw-1; Tue, 11 Apr 2023 05:42:56 -0400
X-MC-Unique: xhBo02srOdWHTMPVaHg5Dw-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 02E7D85A5B1;
	Tue, 11 Apr 2023 09:42:56 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.194.67])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D6084020C80;
	Tue, 11 Apr 2023 09:42:55 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id D00441802393; Tue, 11 Apr 2023 11:42:53 +0200 (CEST)
Date: Tue, 11 Apr 2023 11:42:53 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Abdul Lateef Attar <abdattar@amd.com>
Cc: devel@edk2.groups.io, Abdul Lateef Attar <AbdulLateef.Attar@amd.com>, 
	Paul Grimes <paul.grimes@amd.com>, Garrett Kirkendall <garrett.kirkendall@amd.com>, 
	Abner Chang <abner.chang@amd.com>, Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>, 
	Rahul Kumar <rahul1.kumar@intel.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library
Message-ID: <iwiosjhv5i75ahzrmp6qelp6vggcf56bl5j4rfj3mthycicbki@amujw7z55mq6>
References: <cover.1681121324.git.abdattar@amd.com>
 <da1e86485bec1b60196c467772cd255814a12980.1681121324.git.abdattar@amd.com>
MIME-Version: 1.0
In-Reply-To: <da1e86485bec1b60196c467772cd255814a12980.1681121324.git.abdattar@amd.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> Uses new SmmSmramSaveStateLib library,
> which fix the CI failure.

What is the exact failure you are seeing?

> +  SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/IntelSmmSmramSaveStateLib.inf

This should be the AMD version.  KVM uses the AMD smram state.

Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use
actually use the new SmmSmramSaveStateLib library, and once this
has been done it should be possible to remove
OvmfPkg/Include/Register/QemuSmramSaveStateMap.h

take care,
  Gerd