From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Michael Brown <mcb30@ipxe.org>,
devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer
Date: Thu, 20 Jul 2023 10:30:04 +0200 [thread overview]
Message-ID: <izdgjhorabv7d742eqjfm4ncuzvjrrybrr5pr6riy43jj7lntc@m3c2twntyt3x> (raw)
In-Reply-To: <CAMj1kXGTGTFbXVCp_rgJ_pXV9reiozM=W1XR1VQs1kzKUOtG7g@mail.gmail.com>
Hi,
> > On a quick review of the code, there appear to be other points that also
> > modify mReservedMemBitmap (IoMmuAllocateCommonBuffer() and
> > IoMmuFreeCommonBuffer()). I'd guess that these also need to raise to
> > TPL_NOTIFY, but I'm not familiar with the code so I don't know if
> > there's anything that makes this unnecessary.
> >
>
> Thanks for mentioning that - perhaps Gerd could have another look? (I
> merged the v2 already)
Patch sent. Same pattern. Didn't notice we have that twice (once for
explicitly allocating buffers and once for internally used bounce
buffers).
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107090): https://edk2.groups.io/g/devel/message/107090
Mute This Topic: https://groups.io/mt/100233359/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-07-20 8:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 11:33 [edk2-devel] [PATCH 1/1] OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer Gerd Hoffmann
2023-07-19 16:04 ` Michael Brown
2023-07-19 16:31 ` Gerd Hoffmann
2023-07-19 16:52 ` Ard Biesheuvel
2023-07-19 17:40 ` Michael Brown
2023-07-19 22:06 ` Ard Biesheuvel
2023-07-20 8:30 ` Gerd Hoffmann [this message]
2023-07-20 8:28 ` Gerd Hoffmann
2023-07-20 12:45 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=izdgjhorabv7d742eqjfm4ncuzvjrrybrr5pr6riy43jj7lntc@m3c2twntyt3x \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox