From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ACA1A740035 for ; Thu, 20 Jul 2023 08:30:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7AF1Epv5bAy5ZomXUTWOL8ClYnPwBZXrl6EcPK2ea5c=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-Received:X-MC-Unique:X-Received:X-Received:X-Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:X-Scanned-By:X-Mimecast-Spam-Score:X-Mimecast-Originator:Precedence:List-Unsubscribe:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:X-Gm-Message-State:Content-Type:Content-Disposition; s=20140610; t=1689841809; v=1; b=CYg+lbf6nSkzWmAkqE53MOZ/9Srd+TxYz/Q3J/VK0RS8/1aRWR4ynWMrKRpia5w3zZKuVzrE 1YTCed9pdGy1WzQ7sEtuNj3p3kf649SUMHWh1OU5ou2Dt0o+yNZ/O0JrPx78z0Y+cHjTq0zkOA5 zuSaitmSzdGhMTFh1BJyYopE= X-Received: by 127.0.0.2 with SMTP id 0jv1YY7687511xaWBn1LIwLW; Thu, 20 Jul 2023 01:30:09 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.8354.1689841808771169995 for ; Thu, 20 Jul 2023 01:30:08 -0700 X-Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-347-kCNGsN5XMFqsSuxmAHyrMw-1; Thu, 20 Jul 2023 04:30:06 -0400 X-MC-Unique: kCNGsN5XMFqsSuxmAHyrMw-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E5BED3C16587; Thu, 20 Jul 2023 08:30:05 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D20A1454146; Thu, 20 Jul 2023 08:30:05 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 5E9C218009DC; Thu, 20 Jul 2023 10:30:04 +0200 (CEST) Date: Thu, 20 Jul 2023 10:30:04 +0200 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: Michael Brown , devel@edk2.groups.io, Jiewen Yao , Jordan Justen Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer Message-ID: References: <20230719113317.276124-1-kraxel@redhat.com> <010201896ee54d34-2b5c712c-d799-49b0-a2eb-f0838988b313-000000@eu-west-1.amazonses.com> <010201896f3cee08-297652da-0698-47a8-8832-246bc0d63518-000000@eu-west-1.amazonses.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com X-Gm-Message-State: lp4XRFosUPQGbpUUVO9iIDBNx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CYg+lbf6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > > On a quick review of the code, there appear to be other points that also > > modify mReservedMemBitmap (IoMmuAllocateCommonBuffer() and > > IoMmuFreeCommonBuffer()). I'd guess that these also need to raise to > > TPL_NOTIFY, but I'm not familiar with the code so I don't know if > > there's anything that makes this unnecessary. > > > > Thanks for mentioning that - perhaps Gerd could have another look? (I > merged the v2 already) Patch sent. Same pattern. Didn't notice we have that twice (once for explicitly allocating buffers and once for internally used bounce buffers). take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107090): https://edk2.groups.io/g/devel/message/107090 Mute This Topic: https://groups.io/mt/100233359/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-