public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jiading Zhang" <jdzhang@kunluntech.com.cn>
To: devel@edk2.groups.io
Subject: [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();
Date: Wed, 14 Sep 2022 00:14:47 -0700	[thread overview]
Message-ID: <jLnJ.1663139687887555664.HOSE@groups.io> (raw)

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

The value of InputContext structure is initialized in XhcInitializeDeviceSlot/XhcInitializeDeviceSlot64, it shouldn't be cleared when used in XhcEvaluateContext64().

Signed-off-by: jdzhang <jdzhang@kunluntech.com.cn>
---
MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
index c2906e06fd..efbbe247c1 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
@@ -4021,7 +4021,6 @@ XhcEvaluateContext64 (
// 4.6.7 Evaluate Context
//
InputContext = Xhc->UsbDevContext[SlotId].InputContext;
-  ZeroMem (InputContext, sizeof (INPUT_CONTEXT_64));

InputContext->InputControlContext.Dword2 |= BIT1;
InputContext->EP[0].MaxPacketSize         = MaxPacketSize;
--
2.20.1.windows.1

[-- Attachment #2: Type: text/html, Size: 1258 bytes --]

             reply	other threads:[~2022-09-14  7:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14  7:14 Jiading Zhang [this message]
2022-09-14  8:31 ` [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64(); Wu, Hao A
2022-09-14  9:23   ` Jiading Zhang
2022-09-15  3:26     ` Wu, Hao A
2022-09-20  0:46       ` Jiading Zhang
2022-09-20  3:03         ` Wu, Hao A
2022-09-20  3:16           ` Wu, Hao A
2022-09-20  5:59             ` Jiading Zhang
2022-09-20  6:27               ` Wu, Hao A
2022-09-20 10:00                 ` Jiading Zhang
2022-09-21  1:34                   ` Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jLnJ.1663139687887555664.HOSE@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox