From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A3A0C740038 for ; Wed, 24 Jan 2024 11:53:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4IfmSv0WpQ1Tp3wnIQCjIojNxVrthsBkreT8lqP6DCw=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706097197; v=1; b=LJestouiF6lrLPusDe7pgYY11Ix8vb180WmMqQYvul7a2hVj8pHa5nR0nTTTbU8JFaEVRTwr eL6j3IvHQ7dnFkTy4nJwyLmOAttMxSed4IY0/YU495eRFm6VW6DMH+TOIlD/iHFthgXwDjg6QZH a/65wBqwLojonnWwrDzRu+W8= X-Received: by 127.0.0.2 with SMTP id 2ZgVYY7687511xHwBam6pZ1f; Wed, 24 Jan 2024 03:53:17 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.20681.1706097196520027577 for ; Wed, 24 Jan 2024 03:53:16 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-BXN3vyM-Nje4kSumse0BcQ-1; Wed, 24 Jan 2024 06:53:12 -0500 X-MC-Unique: BXN3vyM-Nje4kSumse0BcQ-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3A9A827D8A; Wed, 24 Jan 2024 11:53:11 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B157D1C060AF; Wed, 24 Jan 2024 11:53:11 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id AB233180038B; Wed, 24 Jan 2024 12:53:10 +0100 (CET) Date: Wed, 24 Jan 2024 12:53:10 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, dougflick@microsoft.com Cc: Saloni Kasbekar , Zachary Clark-williams , "Doug Flick [MSFT]" Subject: Re: [edk2-devel] [PATCH 05/14] NetworkPkg: Ip6Dxe: SECURITY PATCH CVE-2023-45231 - Patch Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FYqSqZ34LAZ0vMZvgO1gGXyDx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=LJestoui; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Jan 23, 2024 at 07:33:28PM -0800, Doug Flick via groups.io wrote: > From: Doug Flick > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4536 > > SECURITY PATCH - Patch > > TCBZ4536 > CVE-2023-45231 > CVSS 6.5 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N > CWE-125 Out-of-bounds Read Same comment for the commit message as for patch #1. > + // > + // Cannot process truncated options. > + // Cannot process options with a length of 0 as there is no Type field. > + // > + if (OptionLen < sizeof (IP6_OPTION_HEADER)) { > + return FALSE; > + } Code change is good (and the commit message describing the change can be as short as the patch itself ;) take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114278): https://edk2.groups.io/g/devel/message/114278 Mute This Topic: https://groups.io/mt/103926735/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-