From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3EE247803D2 for ; Mon, 14 Aug 2023 20:33:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YxXvc+pDJnMNF8Lfe9SRokSFxpe69gChdkvmCHHE90A=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1692045199; v=1; b=T6J7sXnL2BKAmjhV614qauZ60eFMSdRVv9gfjPS1jEOu5Jxvs5SUlQyD/rhg/KCHjcCh2Vw6 wle5foDiLXklNKrSDWz+MUD+drrcpwuuhTjZ9GUdtiapws/ZuHexcvtmNPJvNgAZjVBlOQjH9PJ OphuUl2H71MsfBQBZ++5ijj4= X-Received: by 127.0.0.2 with SMTP id 6VEiYY7687511xelJmlspaFs; Mon, 14 Aug 2023 13:33:19 -0700 X-Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mx.groups.io with SMTP id smtpd.web11.118656.1692045198889330545 for ; Mon, 14 Aug 2023 13:33:19 -0700 X-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D96E2320095A; Mon, 14 Aug 2023 16:33:17 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 14 Aug 2023 16:33:18 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddthedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddtvdenucfhrhhomhepifhrrggv mhgvucfirhgvghhorhihuceoghhrrggvmhgvseigohhrrgdrohhrghdruhhkqeenucggtf frrghtthgvrhhnpefgieegieejteelteeulefhffeiiefhffelhfffhefghfevtedvhfeu ledvkeettdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehgrhgrvghmvgesgihorhgrrdhorhhgrdhukh X-ME-Proxy: Feedback-ID: i62f7400e:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Aug 2023 16:33:16 -0400 (EDT) Date: Mon, 14 Aug 2023 21:33:13 +0100 From: "Graeme Gregory" To: Marcin Juszkiewicz Cc: devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 0/3] Platform/QemuSbsa: add GIC ITS Message-ID: References: <20230719120842.1120001-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 In-Reply-To: <20230719120842.1120001-1-marcin.juszkiewicz@linaro.org> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,graeme@xora.org.uk List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bHWwCr7YG3Lh3qJszJEDEmjLx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=T6J7sXnL; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Patch series seems sane to me. Reviewed-by: Graeme Gregory (I seem to be moving further and further from ARM development and even further from SBSA machine development so Ill probably remove myself as a reviewer for this machine) On Wed, Jul 19, 2023 at 02:08:39PM +0200, Marcin Juszkiewicz wrote: > SBSA Reference Platform can have GIC ITS present. And when it has then > we can have complex PCI Express setup (and some other things). > > First patch adds support for GIC ITS. Address is read from TF-A via SMC > call. IORT is generated, MADT has ITS information. Linux boots and sees > GIC ITS as expected. SMMU information is also provided in IORT and used. > > Second patch introduces PcdSmmuBase variable to avoid using magic number > in IORT generation. > > Third patch takes care of system where GIC ITS is not present (like QEMU > 8.0). If GIC ITS address is not set then there is no mention of it in > MADT and there is no IORT, Linux boots. > > Changes since v2: > - no ITS == no IORT > > Changes since v1: > - IORT is generated in C > - no ITS == no ITS node in IORT > - introduced PcdSmmuBase > > Marcin Juszkiewicz (2): > Platform/QemuSbsa: add dynamic PcdSmmuBase > Platform/SbsaQemu: handle systems without GIC ITS > > Shashi Mallela (1): > Platform/SbsaQemu: add GIC ITS support > > Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 4 + > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 4 + > .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 + > .../SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 2 + > .../SbsaQemuPlatformDxe.inf | 1 + > .../Include/IndustryStandard/SbsaQemuAcpi.h | 11 + > .../Include/IndustryStandard/SbsaQemuSmc.h | 1 + > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 208 +++++++++++++++++- > .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 10 + > 9 files changed, 241 insertions(+), 1 deletion(-) > > -- > 2.41.0 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107734): https://edk2.groups.io/g/devel/message/107734 Mute This Topic: https://groups.io/mt/100233784/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-