From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 93D249416E5 for ; Tue, 7 Nov 2023 09:48:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wTwByVjn1XvTkKCjCfLcN6E+TbT62hnMnhT5qVLg+X4=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1699350486; v=1; b=dmYwNVVrTuapUjkLHJuJ1aifjTSYY3wHG8y8+42QjGD4yXZ8HQUaWqMKiZFlgHVYJpQ/Ez9N N1R6Bj1IZrQ1CtCCNmZ2YZK7junJO7OjhjH+dDRTJSEIV6FTfmTQ0llvLxBGCNS7j8GKqMEhNcD lyUnyI533Bd0panok1Xfo0zM= X-Received: by 127.0.0.2 with SMTP id KRrbYY7687511xZFIZIiiI2G; Tue, 07 Nov 2023 01:48:06 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.6748.1699350485549807683 for ; Tue, 07 Nov 2023 01:48:05 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-0v4Ce-r6PoSWmU_iBeCPug-1; Tue, 07 Nov 2023 04:47:58 -0500 X-MC-Unique: 0v4Ce-r6PoSWmU_iBeCPug-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C6C2480F90F; Tue, 7 Nov 2023 09:47:57 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.119]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59BF21C060AE; Tue, 7 Nov 2023 09:47:57 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 10EC91800DDB; Tue, 7 Nov 2023 10:47:56 +0100 (CET) Date: Tue, 7 Nov 2023 10:47:56 +0100 From: "Gerd Hoffmann" To: Chao Li Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Xianglai Li Subject: Re: [edk2-devel] [PATCH v2 20/30] OvmfPkg/LoongArchVirt: Add serial port library Message-ID: References: <20231106032521.2251143-1-lichao@loongson.cn> <20231106032945.2285855-1-lichao@loongson.cn> MIME-Version: 1.0 In-Reply-To: <20231106032945.2285855-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: iWIzjPlsA4Mrnl3vnZJS3Y3Rx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dmYwNVVr; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Nov 06, 2023 at 11:29:45AM +0800, Chao Li wrote: > Add two libraries named Fdt16550SerialPortHookLib and > EarlyFdtSerialPortLib16550, requested by LoongArch virtual > machine. Moving libs from ArmVirtPkg to OvmfPkg (so non-arm archs can use the libs too) is perfectly fine. I think this should be done here instead of copying the code. I suspect the same applies to some of the following patches in this series (looked at the subject lines only so far though). take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110830): https://edk2.groups.io/g/devel/message/110830 Mute This Topic: https://groups.io/mt/102413885/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-