From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0CBD5AC0D62 for ; Tue, 27 Feb 2024 11:40:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vD0hD5gYmrwb17gJy/MKQM+X7WIaqAK+cMAYeclY6/c=; c=relaxed/simple; d=groups.io; h=Date:From:To:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1709033999; v=1; b=m887YUImtuNYkvzwL/QIOHy1mnw3gY6fGDZXdMPwvccsFF4lFU1l8QgdtGnWR5AG1vMINgyN j4DJN7e8GIv/twFKEaY3+urPoffUifXLLRCKe1cdI4JiXDYoUoq1fm23tmOkYkMRoOfv4WK0VyA L89QBOb3/PNuZIDwdmI/5lhs= X-Received: by 127.0.0.2 with SMTP id 9StYYY7687511xENngyUWXby; Tue, 27 Feb 2024 03:39:59 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.10355.1709033998871524096 for ; Tue, 27 Feb 2024 03:39:59 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-401-sQxN74klOqe9uSZtbr7d9w-1; Tue, 27 Feb 2024 06:39:56 -0500 X-MC-Unique: sQxN74klOqe9uSZtbr7d9w-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D3B9185A788; Tue, 27 Feb 2024 11:39:56 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 389232166B33; Tue, 27 Feb 2024 11:39:56 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 2524A18009BA; Tue, 27 Feb 2024 12:39:55 +0100 (CET) Date: Tue, 27 Feb 2024 12:39:55 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, mikuback@linux.microsoft.com Subject: Re: [edk2-devel] CodeQL Analysis in edk2 Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: d45hYWqDuym3PKoocNU8hueCx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=m887YUIm; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > I am hoping we can work together to improve the overall quality of the > code and minimize the number of CodeQL alerts. Seems CodeQL now runs as part of CI and flags issues it has found. It complains about a possible NULL pointer dereference: https://github.com/tianocore/edk2/runs/22021016348 This is not correct, but I doubt code analysis will ever be clever enough to figure this automatically. So I've added an ASSERT() explicitly saying so, which should help both human reviewers and code analyzers. Apparently that does not change anything for CodeQL though. I guess the CodeQL config must be updated so it knows what ASSERT() means? Maybe it is ignored simply because it is upper case (unlike the standard C library version which is lower case)? thanks & take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116028): https://edk2.groups.io/g/devel/message/116028 Mute This Topic: https://groups.io/mt/102444916/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-