From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6A77DAC0D1A for ; Tue, 19 Mar 2024 08:03:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+EQUCaJ3z24ZzxiGOHpAw0YgAvJGn/H46Oh40g2m32w=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1710835389; v=1; b=K9ofCJlEcXTLsX1tnFLfxCq0ji5KnpYhx76V8C5m5MP19t4DqAINqMBMRVAa17798o/3aomj vMBPLC7jDunljRBAp8bzL7Kv/NXC21qUk534q2bo+aVmNSR31NeK8ouL/jaOVN7nWQ+ZB+iilmM IDRBpxT9BXnk9YixuREQTDrNOKe5SjTr28GeQE+Xx0/mKX+mKPzdbW3VRaUADAGoqpqV9Mi0TVz JdDkqlecpwFiDhINsilybduq81HuI80h1pBcsoMwlyavNFGyjacIqVHC/GXiBVh5FKgoEsLD3JL fmZb+Y7uwToNLi7rRU1vUi8uCH6Mpq4lun+ZaNTuPzjWw== X-Received: by 127.0.0.2 with SMTP id 6YmNYY7687511xByIFsaCOso; Tue, 19 Mar 2024 01:03:09 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.9782.1710835389145385244 for ; Tue, 19 Mar 2024 01:03:09 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-46-9g3ll64EOHeG_jgMdxJkmA-1; Tue, 19 Mar 2024 04:03:06 -0400 X-MC-Unique: 9g3ll64EOHeG_jgMdxJkmA-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 27AF08F8A85; Tue, 19 Mar 2024 08:03:06 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.254]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67D83111E5; Tue, 19 Mar 2024 08:03:05 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 5E2F51800D65; Tue, 19 Mar 2024 09:03:00 +0100 (CET) Date: Tue, 19 Mar 2024 09:03:00 +0100 From: "Gerd Hoffmann" To: Chao Li Cc: lixianglai , devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian Subject: Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib Message-ID: References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093919.1254515-1-lichao@loongson.cn> <7nqe7k3oi3cph7mhqc4t5ea7qair3u2i7dy6oli6wurovyaoqa@apkw6d7gneam> <51c896fa-60bb-127f-c346-dc69179d288f@loongson.cn> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 19 Mar 2024 01:03:09 -0700 Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AOrml01OcLkUcCs4xnEImXg1x7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=K9ofCJlE; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > > > I can't tell the implementation scheme of the current lib and existing > > > lib implementation scheme which one is better, Could you give we some > > > advice? > > I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as > > it is not really loongarch-specific. > > > > If you want try switch aarch64 to use the same code that'll be great, > > but sorting that out later is also fine with me. > > If you think this design is looks better, then I'm prepare to commit this > change under the OvmfPkg/Library as a public library. And I will enable it > in aarch64 after merging this change, because I think it may be tweaked and > validated in aarch64 for many platforms. Do you think that is good? The VirtNorFlashDxe is optimized for qemu-emulated pflash. It tries to avoid switching between read and write mode much, because that operation has a significant overhead in virtualization. So it's really only used by ArmVirtPkg and not lots of other arm platforms. Doing it separate from this patch series makes sense nevertheless. Speaking of this series: maybe split it into two? The first part of this series with the Mde*Pkg + UefiPkg changes looks almost ready to merge to me, so maybe we can get that in while still sorting out the remaining issues in the OvmfPkg patches ... take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116879): https://edk2.groups.io/g/devel/message/116879 Mute This Topic: https://groups.io/mt/104859896/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-