public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: gordontcp@gmail.com
To: devel@edk2.groups.io
Subject: Capsule update with USBIO in FmpDxe
Date: Thu, 28 Jul 2022 20:28:13 -0700	[thread overview]
Message-ID: <m8qQ.1659065293328192904.Ru1s@groups.io> (raw)

[-- Attachment #1: Type: text/plain, Size: 3180 bytes --]

In \FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLib.c There are comments for RegisterFmpInstaller:

/**
 Used to pass the FMP install function to this lib.  This allows the library to
 have control of the handle that the FMP instance is installed on.  This allows
 the library to use DriverBinding protocol model to locate its device(s) in the
 system.

 @param[in] Func  Function pointer to FMP install function.

 @retval EFI_SUCCESS       Library has saved function pointer and will call
                           function pointer on each DriverBinding Start.
 @retval EFI_UNSUPPORTED   Library doesn't use driver binding and only supports
                           a single instance.
 @retval other error       Error occurred.  Don't install FMP

**/
EFI_STATUS
EFIAPI
RegisterFmpInstaller (
 IN FMP_DEVICE_LIB_REGISTER_FMP_INSTALLER Func
 )
{
 //
 // This is a system firmware update that does not use Driver Binding Protocol
 //
 return EFI_UNSUPPORTED;
}

However, since the ‘RegisterFmpInstaller’ of the example directly returns EFI_UNSUPPORTED , it does not demonstrate how to handle the DriverBinding protocol. In addition, I refer to the example of \MdeModulePkg\Bus\Usb\UsbMouseAbsolutePointerDxe adding the driverbinding protocol to locate the USBMouse device to the 'RegisterFmpInstaller' function. And set the return value of RegisterFmpInstaller to EFI_SUCCESS. where RegisterFmpInstaller is in the following file:

edk2-platforms\Platform\Intel\Vlv2TbltDevicePkg\Feature\Capsule\Library\FmpDeviceLibSample

Then tested on Minnowboard.

Test command: CapsuleApp.efi Red.cap

The test results are as follows:

* 

During the Capsule update process, when FmpDeviceSetImageWithStatus is executed, ‘USBMouseAbsolutePointerDriverBindingSupported' has not been executed, that is, USB Device IO cannot be operated yet.

* 

After USBMouseAbsolutePointerDriverBindingSupported is executed, USBIO can be operated, but at this time 'FmpDeviceSetImageWithStatus' has been executed, that is, capsule update time has passed and cannot be processed.

* 

I also refer to the method of Locate spiFlash protocol in ‘PlatformFlashAccessLib.c’, instead of using DriverBinding model, I directly Locate USBIo Protocol, which is written as follows:

Status = gBS->LocateProtocol(&gEfiUsbIoProtocolGuid, NULL, (VOID**)&gUsbIOWDT);

But the returned value is Status: EFI_NOT_FOUND. The file full path is as follows:

\edk2-platforms\Platform\Intel\Vlv2TbltDevicePkg\Feature\Capsule\Library\PlatformFlashAccessLib\PlatformFlashAccessLib.c

My questions are as follows:

* To operate USB Io in FMPDxe driver, should I use driverbinding protocol in RegisterFmpInstaller? Or can use LocateProtocol directly? Or is there any other way to handle it?
* Are there example codes of how RegisterFmpInstaller handles the driverbinding protocol or other method such as LocateProtocol?
* When processing the Capsule update (FmpDeviceSetImageWithStatus), the USBMouseAbsolutePointerDriverBindingSupported has not been executed. How should I deal with it?

Any suggestion is highly appreciated.

Thanks!

Best Regards,

[-- Attachment #2: Type: text/html, Size: 15490 bytes --]

             reply	other threads:[~2022-07-29  3:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29  3:28 gordontcp [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-26 11:32 Capsule update with USBIO in FmpDxe gordontcp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m8qQ.1659065293328192904.Ru1s@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox