From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6EABEAC0E3C for ; Wed, 28 Feb 2024 08:40:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TWfIIYUKM4wpX6CM4xuFzpcyiB63n+XqnH6mxAQWcM4=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1709109655; v=1; b=djpbK9FUMpkRQUZbOD7SoGPXoCoCHryl/gtd06SslCLBdEghwMxLS7waV0eKA+nG11ZXCFtE C5X/7xXkvMeIYn+Q12cwPIIYRpUAbDAOekxPE2q7c1g+WhMV0rk1PS1Zz2y/0KRR6iygKlBFOFc 54ekqb1QZTOsV9R9gaqwWQT4= X-Received: by 127.0.0.2 with SMTP id x0zuYY7687511xKjh3vZKfG5; Wed, 28 Feb 2024 00:40:55 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.9130.1709109654520167142 for ; Wed, 28 Feb 2024 00:40:54 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-8_NWepteN3Ox675hp28O4g-1; Wed, 28 Feb 2024 03:40:50 -0500 X-MC-Unique: 8_NWepteN3Ox675hp28O4g-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6189D800074; Wed, 28 Feb 2024 08:40:49 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD1F91121306; Wed, 28 Feb 2024 08:40:48 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id BD3891801480; Wed, 28 Feb 2024 09:40:47 +0100 (CET) Date: Wed, 28 Feb 2024 09:40:47 +0100 From: "Gerd Hoffmann" To: Tom Lendacky Cc: devel@edk2.groups.io, Ard Biesheuvel , Erdem Aktas , Jiewen Yao , Laszlo Ersek , Liming Gao , Michael D Kinney , Min Xu , Zhiguang Liu , Rahul Kumar , Ray Ni , Michael Roth Subject: Re: [edk2-devel] [PATCH v2 14/23] Ovmfpkg/CcSvsmLib: Create CcSvsmLib to handle SVSM related services Message-ID: References: <56d5ceff99e0be9e4e261476deba6a9b01da5c81.1708623001.git.thomas.lendacky@amd.com> MIME-Version: 1.0 In-Reply-To: <56d5ceff99e0be9e4e261476deba6a9b01da5c81.1708623001.git.thomas.lendacky@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RoiYzXDbYfu9tEnVnmjq865Fx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=djpbK9FU; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > +/** > + Perform a native PVALIDATE operation for the page ranges specified. > + > + Validate or rescind the validation of the specified pages. > + > + @param[in] Info Pointer to a page state change structure > + > +**/ > +STATIC > +VOID > +BasePvalidate ( > + IN SNP_PAGE_STATE_CHANGE_INFO *Info > + ) This is not mentioned in the commit message. Looks like you are moving or copying code from BaseMemEncryptSevLib. Moving code is best done with a patch doing the move only, without other functional changes. If that can't be done easily this should explained in the commit message. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116098): https://edk2.groups.io/g/devel/message/116098 Mute This Topic: https://groups.io/mt/104512963/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-