Re: [edk2-devel] [PATCH v2 0/5] OvmfPkg: Add support for 5-level paging

["Gerd Hoffmann" <kraxel@redhat.com>]

On Wed, Jan 31, 2024 at 06:19:38AM +0000, Xu, Min M wrote:
> On Tuesday, January 30, 2024 8:32 PM, Gerd Hoffmann wrote:
> > 
> > Patch #1 has been submitted separately last week.
> > Intewl raised concerns that removing or renaming the PCD breaks platforms,
> > so I'm just doing the minimal fix here.
> > 
> > Patch #2 + #3 update OvmfPkg ResetVector and PlatformInitLib for 5-level
> > paging support.
> > 
> > Tom, Min: can you test this patch set with SEV / TDX?
> > 
> We test the patch in TDX with PcdUse5LevelPageTable TRUE. It failed if the td-guest is configured with multiple vCpus. We're investigating what happened.

My first guess would be we need to somehow propagate to the APs that
cr4.la57 must be set.

Maybe use
TDX_WORK_AREA_PGTBL_READY_4_LEVEL +
TDX_WORK_AREA_PGTBL_READY_5_LEVEL ?

Or add a field for cr4 to the work area?

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114867): https://edk2.groups.io/g/devel/message/114867
Mute This Topic: https://groups.io/mt/104052206/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-