From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0436274003B for ; Wed, 31 Jan 2024 08:24:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=eVrGCKPpAHlNEqSsfNpJbcEEC6YwDYcj5CzrZcrvtG0=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706689468; v=1; b=ErsrndVimbjGqMUcVOqBD0y7dtJAhnb+eWA+1ENe2dFLr0zfH/6v1W8qjs6EDdux3g4lKtf+ 9KMDkLT2WznOnJFe7mBWrKeCSEnvDgR94WcaUXbwxW7+BnDZOmG/BytuEE6Kk00wMCtaWlPMFLc INH6XKEE1CTnVYVPamdA28wM= X-Received: by 127.0.0.2 with SMTP id 6Mb6YY7687511xqjBpJ68Yde; Wed, 31 Jan 2024 00:24:28 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.9799.1706689467656306165 for ; Wed, 31 Jan 2024 00:24:27 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-zQX3KJfZNB2rKgSBS4aFxw-1; Wed, 31 Jan 2024 03:24:23 -0500 X-MC-Unique: zQX3KJfZNB2rKgSBS4aFxw-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F4D710B7264; Wed, 31 Jan 2024 08:24:23 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.243]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E57B2026D66; Wed, 31 Jan 2024 08:24:23 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C4C5B1800DDC; Wed, 31 Jan 2024 09:24:21 +0100 (CET) Date: Wed, 31 Jan 2024 09:24:21 +0100 From: "Gerd Hoffmann" To: "Xu, Min M" Cc: "devel@edk2.groups.io" , "Aktas, Erdem" , Oliver Steffen , "Yao, Jiewen" , Ard Biesheuvel , Tom Lendacky , Michael Roth , Liming Gao , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v2 0/5] OvmfPkg: Add support for 5-level paging Message-ID: References: <20240130123204.764453-1-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: U2XWcOPzYeSNYVaJxvWN76mAx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ErsrndVi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Jan 31, 2024 at 06:19:38AM +0000, Xu, Min M wrote: > On Tuesday, January 30, 2024 8:32 PM, Gerd Hoffmann wrote: > > > > Patch #1 has been submitted separately last week. > > Intewl raised concerns that removing or renaming the PCD breaks platforms, > > so I'm just doing the minimal fix here. > > > > Patch #2 + #3 update OvmfPkg ResetVector and PlatformInitLib for 5-level > > paging support. > > > > Tom, Min: can you test this patch set with SEV / TDX? > > > We test the patch in TDX with PcdUse5LevelPageTable TRUE. It failed if the td-guest is configured with multiple vCpus. We're investigating what happened. My first guess would be we need to somehow propagate to the APs that cr4.la57 must be set. Maybe use TDX_WORK_AREA_PGTBL_READY_4_LEVEL + TDX_WORK_AREA_PGTBL_READY_5_LEVEL ? Or add a field for cr4 to the work area? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114867): https://edk2.groups.io/g/devel/message/114867 Mute This Topic: https://groups.io/mt/104052206/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-