From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 499D59414AB for ; Fri, 1 Nov 2024 09:31:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9ho994WqZoljKpiemQMLKzJi+2BRt5yGlSkbFQBd7po=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240830; t=1730453468; v=1; x=1730712666; b=ObOFePwfNPgw8M31YHzvHqWC4QE2ojhLFBpeXYfkxrBO2MuMnVh9NGm/KXQ4WhNbZ00tZL8S njZH9y9bIGikGSM259sIEpuN2uUwKb/HBpZfnNDSiJIKj9j62ookDUd48kLUmRNVm4uVhwOsi3/ NQGdmCfJ69x0tq8l9ZGj3w3p1q6Cl+UEwMcIDH64BQT8QzksKnKwA8BNHM6/RfzsN95+hEuGJaT zlmw24P+rwRcUi/KuWK49mLYd0r2PmWjdzkRsaTQEFA1ZM7sKJWUlsgxSa5+NfYdIgTz39J9n2K Y32CLj1Z5pp6+TZoO0tz8aKAnfRP3YVOLJN9CgT5F5VpA== X-Received: by 127.0.0.2 with SMTP id F6cZYY7687511x2pskiDimlg; Fri, 01 Nov 2024 02:31:06 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.33859.1730453465795488412 for ; Fri, 01 Nov 2024 02:31:06 -0700 X-Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-Hb7BszmUMv2D2URPU5asPQ-1; Fri, 01 Nov 2024 05:31:03 -0400 X-MC-Unique: Hb7BszmUMv2D2URPU5asPQ-1 X-Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7FBA5195608A; Fri, 1 Nov 2024 09:31:02 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.174]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1A7BB195605A; Fri, 1 Nov 2024 09:31:02 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 00FD91800929; Fri, 1 Nov 2024 10:30:59 +0100 (CET) Date: Fri, 1 Nov 2024 10:30:59 +0100 From: "Gerd Hoffmann" To: Stefano Garzarella Cc: Oliver Steffen , devel@edk2.groups.io, Jiewen Yao , Zachary Clark-williams , Saloni Kasbekar , Doug Flick , Daniel Berrange , Cong Li Subject: Re: [edk2-devel] OVMF Issue with Netboot, VirtioRng, and both COM1/COM2 configured Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 01 Nov 2024 02:31:06 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zoxPAim3KuHfY1UvKsH8RTl3x7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=ObOFePwf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > By analyzing the calls to the dispatcher (`gDS->Dispatch ()`) I found > that when we only have COM1, EfiBootManagerConnectDevicePath() at some > point invokes `gDS->Dispatch ()` after VirtioRng has started. This call > will then get DxeNetLib loaded. Ok, so it is probably a good idea to explicitly request a dispatch after activating virtio-rng, so we do not depend on this happening by pure luck for other reasons: --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c @@ -670,6 +670,7 @@ ConnectVirtioPciRng ( if (EFI_ERROR (Status)) { goto Error; } + gDS->Dispatch (); } return EFI_SUCCESS; [ untested patch, and we probably should do something similar for ArmVirt, /me goes continue walking through my email backlog now ] take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120699): https://edk2.groups.io/g/devel/message/120699 Mute This Topic: https://groups.io/mt/109008158/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-