From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bounce+27952+116021+7686176+12367111@groups.io>
Received: from mail02.groups.io (mail02.groups.io [66.175.222.108])
by spool.mail.gandi.net (Postfix) with ESMTPS id AD751740045
for <rebecca@openfw.io>; Tue, 27 Feb 2024 10:19:04 +0000 (UTC)
DKIM-Signature: a=rsa-sha256; bh=QxV55R47mnDZEOV5U4FjccEqfL5MwqpLRDuYKMSu1LM=;
c=relaxed/simple; d=groups.io;
h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition;
s=20140610; t=1709029143; v=1;
b=F2QE+7MZVp8h/Ae+zXA+6ETYQ3YvecmEiMOENabh+mnn/jsTVEcVQbKaU/SSX2GrWf/+9Wa9
XeuKbRgjizy49BfvlRCWIpXgHxu49L3blWoM6tLw8qrXScbKMvS/HUod83TAWhwA5W/ksOB6o0x
4uTPkabK91HD3x0RKXbHx68E=
X-Received: by 127.0.0.2 with SMTP id B0FOYY7687511xILJ2nJTTiX; Tue, 27 Feb 2024 02:19:03 -0800
X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mx.groups.io with SMTP id smtpd.web11.9079.1709029142697916319
for <devel@edk2.groups.io>;
Tue, 27 Feb 2024 02:19:02 -0800
X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-152-Su4KQoOKP6WyDN263eTYUg-1; Tue, 27 Feb 2024 05:18:58 -0500
X-MC-Unique: Su4KQoOKP6WyDN263eTYUg-1
X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F063C185A780;
Tue, 27 Feb 2024 10:18:57 +0000 (UTC)
X-Received: from sirius.home.kraxel.org (unknown [10.39.192.249])
by smtp.corp.redhat.com (Postfix) with ESMTPS id C6553F63F1;
Tue, 27 Feb 2024 10:18:57 +0000 (UTC)
X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
id C667A18009BA; Tue, 27 Feb 2024 11:18:56 +0100 (CET)
Date: Tue, 27 Feb 2024 11:18:56 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Erdem Aktas <erdemaktas@google.com>, Jiewen Yao <jiewen.yao@intel.com>,
Laszlo Ersek <lersek@redhat.com>, Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>, Min Xu <min.m.xu@intel.com>,
Zhiguang Liu <zhiguang.liu@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>, Ray Ni <ray.ni@intel.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [edk2-devel] [PATCH v2 07/23] MdePkg: Avoid hardcoded value for number of Page State Change entries
Message-ID: <nx4jrdsk42phbsltaif7a2ab5kewp4y25sufhc3vnelunrm6sl@bt6ub4odiagb>
References: <cover.1708623001.git.thomas.lendacky@amd.com>
<01099a06092b17a9866d813d22ea46a006dde3f7.1708623001.git.thomas.lendacky@amd.com>
MIME-Version: 1.0
In-Reply-To: <01099a06092b17a9866d813d22ea46a006dde3f7.1708623001.git.thomas.lendacky@amd.com>
X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Precedence: Bulk
List-Subscribe: <mailto:devel+subscribe@edk2.groups.io>
List-Help: <mailto:devel+help@edk2.groups.io>
Sender: devel@edk2.groups.io
List-Id: <devel.edk2.groups.io>
Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io
Reply-To: devel@edk2.groups.io,kraxel@redhat.com
List-Unsubscribe-Post: List-Unsubscribe=One-Click
List-Unsubscribe: <https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/plugh>
X-Gm-Message-State: QHchCu4WrClicTJpCJUba46kx7686176AA=
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-GND-Status: LEGIT
Authentication-Results: spool.mail.gandi.net;
dkim=pass header.d=groups.io header.s=20140610 header.b=F2QE+7MZ;
dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none);
spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io
On Thu, Feb 22, 2024 at 11:29:46AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> The SNP_PAGE_STATE_MAX_ENTRY is based on the number of entries that can
> fit in the GHCB shared buffer. As a result, the SNP_PAGE_STATE_CHANGE_INFO
> structure maps the full GHCB shared buffer based on the shared buffer size
> being 2032 bytes.
>
> Instead of using a hardcoded value for SNP_PAGE_STATE_MAX_ENTRY, use a
> build calculated value. Since the SNP_PAGE_STATE_CHANGE_INFO is used as a
> mapping, eliminate the hardcoded array size so that the structure can be
> used based on any size buffer.
>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> MdePkg/Include/Register/Amd/Ghcb.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/MdePkg/Include/Register/Amd/Ghcb.h b/MdePkg/Include/Register/Amd/Ghcb.h
> index 432d67e3e223..0cdc00627472 100644
> --- a/MdePkg/Include/Register/Amd/Ghcb.h
> +++ b/MdePkg/Include/Register/Amd/Ghcb.h
> @@ -197,13 +197,14 @@ typedef struct {
> UINT32 Reserved;
> } SNP_PAGE_STATE_HEADER;
>
> -#define SNP_PAGE_STATE_MAX_ENTRY 253
> -
> typedef struct {
> SNP_PAGE_STATE_HEADER Header;
> - SNP_PAGE_STATE_ENTRY Entry[SNP_PAGE_STATE_MAX_ENTRY];
> + SNP_PAGE_STATE_ENTRY Entry[];
> } SNP_PAGE_STATE_CHANGE_INFO;
Good.
> +#define SNP_PAGE_STATE_MAX_ENTRY \
> + ((sizeof (((GHCB *)0)->SharedBuffer) - sizeof (SNP_PAGE_STATE_HEADER)) / sizeof (SNP_PAGE_STATE_ENTRY))
Can be dropped I think, after applying patch #6 BaseMemEncryptSevLib
does not use SNP_PAGE_STATE_MAX_ENTRY any more.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116021): https://edk2.groups.io/g/devel/message/116021
Mute This Topic: https://groups.io/mt/104512946/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-