From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 655C994141C for ; Wed, 17 Apr 2024 09:35:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/LRCYaW6MHuGTI88QarY6cxwNaRNKUFOSNUQMoz6OGg=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1713346525; v=1; b=R9EDLjuXhZRydb+nbODDrovT4+MTtkhw74hr/WGX0/HEc+WudnlzbUESVfow38ejAf6rabkA HDUaSUxzjo2IznjFvAwQCj0fYWLaEth4oomuyAtnA/cF91LXwfCnMJH6dHkorCDdXIMjzmuaEcy 5v0oxsL+Wed0aw4SXkpJqLqKXOOgiUlFKx50BOK1YRX1ZqFUdNKxs21qc+OQwKgzt/cBCAdt7h3 Ynk3x9kjpUM9UHY8uy2kDbxWff6JW40NKPOCE1uRlUkanCqegIHy3/kXBJLeQg/cIYXZHWNn+Xg +R8hUmeWOQZs4PA6we4o0A9oTa0QRybbT4HDcg82BlEsg== X-Received: by 127.0.0.2 with SMTP id ruE2YY7687511x26TJmZlJ0u; Wed, 17 Apr 2024 02:35:25 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.8686.1713346524125384923 for ; Wed, 17 Apr 2024 02:35:24 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-I6EyWjUBOsG5my_GGVfABQ-1; Wed, 17 Apr 2024 05:35:16 -0400 X-MC-Unique: I6EyWjUBOsG5my_GGVfABQ-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 383E48007BA; Wed, 17 Apr 2024 09:35:16 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.192.214]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0AACC13FA2; Wed, 17 Apr 2024 09:35:15 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id C6CABEE1EB; Wed, 17 Apr 2024 11:35:09 +0200 (CEST) Date: Wed, 17 Apr 2024 11:35:09 +0200 From: "Gerd Hoffmann" To: Chao Li Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Leif Lindholm , Sami Mujawar , Sunil V L , Andrei Warkentin Subject: Re: [edk2-devel] [PATCH v1 0/4] Adjust the QemuFwCfgLibMmio and add PEI stage Message-ID: References: <20240417081256.3125187-1-lichao@loongson.cn> MIME-Version: 1.0 In-Reply-To: <20240417081256.3125187-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 17 Apr 2024 02:35:24 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EUcYpV6uXvy81kwE6TFbrxnNx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=R9EDLjuX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Apr 17, 2024 at 04:12:56PM +0800, Chao Li wrote: > Patch1: Added three PCDs for QemuFwCfgLibMmio > Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE > stage library. > Patch3: Added QemuFwCfgMmiLib PEI version > Patch4: Rename QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf and > enable it in AARCH64 and RISCV64. Ok, I see, you are using the PCDs because global variables don't work in PEI. Alternative approach would be to create a HOB for that (see EFI_HOB_PLATFORM_INFO used by X64). Not sure this is a good idea though given that we have three different architectures using that code. Ard, any advise? > OvmfPkg: Add three PCDs for QemuFwCfgLib > OvmfPkg: Separate QemuFwCfgLibMmio.c into two files This patch should be splitted into two, one doing the code split without functional change, and one which switches from global variables to PCDs (or HOB). Otherwise this looks good to me (and I'd suggest to keep and merge this as separate patch series). take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117912): https://edk2.groups.io/g/devel/message/117912 Mute This Topic: https://groups.io/mt/105573103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-