[edk2-devel] Could we reconsider the GitHub stale PR bot please?

[edk2-devel] Could we reconsider the GitHub stale PR bot please?

[Rebecca Cran]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

See the attached screenshot or 
https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .

The PR was marked stale by the bot and the PR author only responded two 
weeks later - which would have been one week too late.

Fortunately I noticed and commented to keep it open, but I think we 
should reconsider the use of the stale bot.


-- 
Rebecca


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120690): https://edk2.groups.io/g/devel/message/120690
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Screenshot_2024-10-28_20-30-55.png --]
[-- Type: image/png, Size: 93833 bytes --]

Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?

[Michael D Kinney]

I believe the timeframe to mark one stale is configurable.

Is there a proposal for a different wait time?

Mike

> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Monday, October 28, 2024 7:35 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Could we reconsider the GitHub stale PR bot please?
> 
> See the attached screenshot or
> https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .
> 
> The PR was marked stale by the bot and the PR author only responded two
> weeks later - which would have been one week too late.
> 
> Fortunately I noticed and commented to keep it open, but I think we
> should reconsider the use of the stale bot.
> 
> 
> --
> Rebecca


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120691): https://edk2.groups.io/g/devel/message/120691
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?

[Rebecca Cran]

How about 6 months? And closing it if there’s been no follow-up to the bot’s comment after 3 months?

Rebecca

On Mon, Oct 28, 2024, at 11:43 PM, Michael D Kinney wrote:
> I believe the timeframe to mark one stale is configurable.
>
> Is there a proposal for a different wait time?
>
> Mike
>
>> -----Original Message-----
>> From: Rebecca Cran <rebecca@bsdio.com>
>> Sent: Monday, October 28, 2024 7:35 PM
>> To: devel@edk2.groups.io
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: Could we reconsider the GitHub stale PR bot please?
>> 
>> See the attached screenshot or
>> https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .
>> 
>> The PR was marked stale by the bot and the PR author only responded two
>> weeks later - which would have been one week too late.
>> 
>> Fortunately I noticed and commented to keep it open, but I think we
>> should reconsider the use of the stale bot.
>> 
>> 
>> --
>> Rebecca
>
>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120692): https://edk2.groups.io/g/devel/message/120692
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?

[Michael D Kinney]

Hi Rebecca,

Here is the link to the full description of the action and all of its settings

	https://github.com/actions/stale

Here is the link to the edk2 repo GitHub Action workflow that uses this action

	https://github.com/tianocore/edk2/blob/master/.github/workflows/stale.yml

Current settings ate 60 days to slate and 7 days to close.

I think you are suggesting changing those to 180 days and 90 days.

Do you want to create a PR with those changes?

Mike



> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Monday, October 28, 2024 11:04 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] Could we reconsider the GitHub stale PR bot
> please?
> 
> How about 6 months? And closing it if there’s been no follow-up to the
> bot’s comment after 3 months?
> 
> Rebecca
> 
> On Mon, Oct 28, 2024, at 11:43 PM, Michael D Kinney wrote:
> > I believe the timeframe to mark one stale is configurable.
> >
> > Is there a proposal for a different wait time?
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: Rebecca Cran <rebecca@bsdio.com>
> >> Sent: Monday, October 28, 2024 7:35 PM
> >> To: devel@edk2.groups.io
> >> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> >> Subject: Could we reconsider the GitHub stale PR bot please?
> >>
> >> See the attached screenshot or
> >> https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .
> >>
> >> The PR was marked stale by the bot and the PR author only responded
> two
> >> weeks later - which would have been one week too late.
> >>
> >> Fortunately I noticed and commented to keep it open, but I think we
> >> should reconsider the use of the stale bot.
> >>
> >>
> >> --
> >> Rebecca
> >
> >
> > 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120693): https://edk2.groups.io/g/devel/message/120693
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?

[Gerd Hoffmann]

On Mon, Oct 28, 2024 at 08:34:34PM -0600, Rebecca Cran wrote:
> See the attached screenshot or
> https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .
> 
> The PR was marked stale by the bot and the PR author only responded two
> weeks later - which would have been one week too late.
> 
> Fortunately I noticed and commented to keep it open, but I think we should
> reconsider the use of the stale bot.

Why is that a problem?  I still get email notifications in case someone
adds a comment to a PR in closed (or merged) state, so updates do not go
unnoticed.  Also it is always possible to re-open closed PRs.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120728): https://edk2.groups.io/g/devel/message/120728
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?

[Rebecca Cran]

On 11/5/24 6:08 AM, Gerd Hoffmann wrote:
> On Mon, Oct 28, 2024 at 08:34:34PM -0600, Rebecca Cran wrote:
>> See the attached screenshot or
>> https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .
>>
>> The PR was marked stale by the bot and the PR author only responded two
>> weeks later - which would have been one week too late.
>>
>> Fortunately I noticed and commented to keep it open, but I think we should
>> reconsider the use of the stale bot.
> Why is that a problem?  I still get email notifications in case someone
> adds a comment to a PR in closed (or merged) state, so updates do not go
> unnoticed.  Also it is always possible to re-open closed PRs.


When I had one of my PRs auto-closed a few months ago I wasn't able to 
re-open it. But that might have been because it was during the freeze.

I was told to create a new PR instead.


-- 
Rebecca



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120729): https://edk2.groups.io/g/devel/message/120729
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?

[Gerd Hoffmann]

On Tue, Nov 05, 2024 at 06:52:42AM -0700, Rebecca Cran wrote:
> On 11/5/24 6:08 AM, Gerd Hoffmann wrote:
> > On Mon, Oct 28, 2024 at 08:34:34PM -0600, Rebecca Cran wrote:
> > > See the attached screenshot or
> > > https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .
> > > 
> > > The PR was marked stale by the bot and the PR author only responded two
> > > weeks later - which would have been one week too late.
> > > 
> > > Fortunately I noticed and commented to keep it open, but I think we should
> > > reconsider the use of the stale bot.
> > Why is that a problem?  I still get email notifications in case someone
> > adds a comment to a PR in closed (or merged) state, so updates do not go
> > unnoticed.  Also it is always possible to re-open closed PRs.
> 
> When I had one of my PRs auto-closed a few months ago I wasn't able to
> re-open it. But that might have been because it was during the freeze.
> 
> I was told to create a new PR instead.

Hmm.  Re-opening not working is bad because we loose the old discussions
when creating a new PR.

But having lots of stale PRs in the list is not nice either.  I don't
like the idea to make the intervals *much* longer.

Having only one week between stale warning and closing is very short,
that is easily missed when going on vacation, extending that (say a
month) looks sensible to me.

The 60 days for "stale due to inactivity" looks fine to me.  I'd leave
that as-is, or maybe extend it a bit to match release cycle length (3
months).

Is it possible to tag PRs as stale for other reasons?  One obvious
candidate would be if it can not be merged any more, i.e. when mergify
asks for a rebase.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120732): https://edk2.groups.io/g/devel/message/120732
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-