From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Corvin Köhne" <corvink@freebsd.org>
Cc: devel@edk2.groups.io,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Rebecca Cran <rebecca@bsdio.com>,
Peter Grehan <grehan@freebsd.org>
Subject: Re: [PATCH 1/1] OvmfPkg/BhyveBhf: install bhyve's ACPI tables
Date: Mon, 17 Apr 2023 14:14:27 +0200 [thread overview]
Message-ID: <o3mkfyyiphvbtqdimvb2yltabrwqzxkfdnnngr42vsl6igzqcy@id45jl6zoxek> (raw)
In-Reply-To: <20230417114601.398383-1-corvink@FreeBSD.org>
On Mon, Apr 17, 2023 at 01:46:01PM +0200, Corvin Köhne wrote:
> It's much easier to create configuration dependend ACPI tables for bhyve
> than for OVMF. For this reason, don't use the statically created ACPI
> tables provided by OVMF. Instead prefer the dynamically created ACPI
> tables of bhyve. If bhyve provides no ACPI tables or we are unable to
> detect those, fall back to OVMF tables.
>
> Ideally, we use the qemu fwcfg interface to pass the ACPI tables from
> bhyve to OVMF. bhyve will support this in the future. However, current
> bhyve executables don't support passing ACPI tables by the qemu fwcfg
> interface. They just copy the ACPI into main memory. For that reason,
> pick up the ACPI tables from main memory.
>
> Implementation is similar to OvmfPkg/XenAcpiPlatformDxe/Xen.c.
Can both Xen and Bhyve share the same implementation?
Given in both cases RAM is scanned for the RSDP I'd expect it should
not be very hard and we avoid duplicating the code.
take care,
Gerd
next prev parent reply other threads:[~2023-04-17 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230417114601.398383-1-corvink@FreeBSD.org>
2023-04-17 11:53 ` [PATCH 1/1] OvmfPkg/BhyveBhf: install bhyve's ACPI tables Rebecca Cran
2023-05-03 2:25 ` Rebecca Cran
2023-05-03 7:43 ` Corvin Köhne
2023-05-03 14:50 ` Rebecca Cran
2023-04-17 12:14 ` Gerd Hoffmann [this message]
2023-04-17 12:45 ` Corvin Köhne
2023-04-17 15:15 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=o3mkfyyiphvbtqdimvb2yltabrwqzxkfdnnngr42vsl6igzqcy@id45jl6zoxek \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox