public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, mike.maslenkin@gmail.com
Cc: Jiewen Yao <jiewen.yao@intel.com>,
	 Ard Biesheuvel <ardb+tianocore@kernel.org>,
	oliver@redhat.com
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtNorFlashDxe: sanity-check variables
Date: Thu, 7 Dec 2023 10:43:22 +0100	[thread overview]
Message-ID: <odgm3kvy5hdqtek6qv6npxoav2j5dayfn53m6lzkp4agqbqlbe@hf2ww2fdxrae> (raw)
In-Reply-To: <CAL77WPA8HQdDepY5_p8PRQT=GZjQB67T04N=K-aKAP3oMotKgA@mail.gmail.com>

  Hi,

> > +      default:
> > +        DEBUG ((
> > +          DEBUG_ERROR,
> > +          "%a: invalid variable state: 0x%x\n",
> > +          __func__,
> > +          VarState
> > +          ));
> 
> Did you want to print VarHeader->State?

Yes, indeed.  Good catch, thank you, will fix send send v2.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112176): https://edk2.groups.io/g/devel/message/112176
Mute This Topic: https://groups.io/mt/102991507/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2023-12-07  9:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 13:51 [edk2-devel] [PATCH 1/1] OvmfPkg/VirtNorFlashDxe: sanity-check variables Gerd Hoffmann
2023-12-06 12:58 ` Mike Maslenkin
2023-12-07  9:43   ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=odgm3kvy5hdqtek6qv6npxoav2j5dayfn53m6lzkp4agqbqlbe@hf2ww2fdxrae \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox