From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.2340.1681800182620031577
 for <devel@edk2.groups.io>;
 Mon, 17 Apr 2023 23:43:03 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b9ltCIlh;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1681800181;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TtWRDMoc+zkQo0lQKMzj4Ynftk3ldLKmxld0gP972XM=;
	b=b9ltCIlhdhz5igX3Q3aJ2ERDpj5n3MgsXAg9GRTrwaluPpJunKgp27xCs61YHzyLk4U0Z4
	1By6NkCWn+dSG/Y1ggGfiLHrsFHQw9Sbr7eomnUQsjO5o1B3aVtUV6yUicur+2xcM+G7mN
	xzw4a4PrX5KQW5s6NGAA73mPftP57nM=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-128-QQMlkkGIOYibxC7c48Hp8w-1; Tue, 18 Apr 2023 02:42:56 -0400
X-MC-Unique: QQMlkkGIOYibxC7c48Hp8w-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DB92F101A54F;
	Tue, 18 Apr 2023 06:42:55 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.149])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 9766A492B0E;
	Tue, 18 Apr 2023 06:42:55 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 8FA65180061C; Tue, 18 Apr 2023 08:42:53 +0200 (CEST)
Date: Tue, 18 Apr 2023 08:42:53 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>
Cc: "Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>, 
	"devel@edk2.groups.io" <devel@edk2.groups.io>, "Grimes, Paul" <Paul.Grimes@amd.com>, 
	"Kirkendall, Garrett" <Garrett.Kirkendall@amd.com>, "Chang, Abner" <Abner.Chang@amd.com>, 
	"Dong, Eric" <eric.dong@intel.com>, "Kumar, Rahul R" <rahul.r.kumar@intel.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, "Yao, Jiewen" <jiewen.yao@intel.com>, 
	"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library
Message-ID: <ofhavgnjj6six46r3oru3zdbuskewhvne2yztuc7qhv2qlyff2@rnwatr7yjvnk>
References: <cover.1681121324.git.abdattar@amd.com>
 <da1e86485bec1b60196c467772cd255814a12980.1681121324.git.abdattar@amd.com>
 <iwiosjhv5i75ahzrmp6qelp6vggcf56bl5j4rfj3mthycicbki@amujw7z55mq6>
 <MN6PR11MB8244C2892035F8DFC1B903BE8C9A9@MN6PR11MB8244.namprd11.prod.outlook.com>
 <PH7PR12MB6466962C7BED09E4E4CB5DA8E09A9@PH7PR12MB6466.namprd12.prod.outlook.com>
 <MN6PR11MB8244D0024F3DCBAADC6E3ED38C9A9@MN6PR11MB8244.namprd11.prod.outlook.com>
 <IA1PR12MB645876A60C9CEC7520C4DBACE09D9@IA1PR12MB6458.namprd12.prod.outlook.com>
 <MN6PR11MB82449A9BFAE0201AD56B4B6E8C9D9@MN6PR11MB8244.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <MN6PR11MB82449A9BFAE0201AD56B4B6E8C9D9@MN6PR11MB8244.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 18, 2023 at 05:38:09AM +0000, Ni, Ray wrote:
> Abdul,
> What prevents you implementing the OVMF version MmSaveStateLib?

Moving the code to a OVMF-specific MmSaveStateLib should work in
any case.

> Or I assume OVMF is emulating AMD CPU, why AMD version MmSaveStateLib cannot support OVMF?

I'd expect that to work.  kvm might not fully emulate every detail of
amd cpu smm mode, but it uses the amd smram register layout, which is
exactly what MmSaveStateLib implements ...

take care,
  Gerd