From: "Gerd Hoffmann" <kraxel@redhat.com>
To: xieyuanh <yuanhao.xie@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
Ray Ni <ray.ni@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Enable execute disable bit.
Date: Mon, 13 Nov 2023 11:36:11 +0100 [thread overview]
Message-ID: <on5pdfe3pnfh62ogkmrdvkkvex64qr64ud76tht3gjwegbfpqk@mcglhp3x2kix> (raw)
In-Reply-To: <20231110103732.1399-1-yuanhao.xie@intel.com>
Hi,
> - GetProcessorNumber (CpuMpData, &ProcessorNumber);
> - RestoreVolatileRegisters (&CpuMpData->CpuData[0].VolatileRegisters, FALSE);
> - InterlockedIncrement ((UINT32 *)&CpuMpData->FinishedCount);
> - PlaceAPInMwaitLoopOrRunLoop (
> - CpuMpData->ApLoopMode,
> - CpuMpData->CpuData[ProcessorNumber].StartupApSignal,
> - CpuMpData->ApTargetCState
> - );
> - ApWakeupFunction (CpuMpData, ProcessorNumber);
> + GetProcessorNumber(CpuMpData, &ProcessorNumber);
> + InterlockedIncrement((UINT32 *)&CpuMpData->FinishedCount);
You have some whitespace changes here makes the patch hard to read and
I also doubt this will pass the uncrustify check in CI.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111131): https://edk2.groups.io/g/devel/message/111131
Mute This Topic: https://groups.io/mt/102504353/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-11-13 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 10:37 [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Enable execute disable bit Yuanhao Xie
2023-11-13 10:36 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=on5pdfe3pnfh62ogkmrdvkkvex64qr64ud76tht3gjwegbfpqk@mcglhp3x2kix \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox