From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BA0FE7803EC for ; Mon, 13 Nov 2023 10:36:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZLXsR42QBwqSb3nUdVR1YV5RJalsJ2ax+cNKH9ZpDQo=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1699871779; v=1; b=KXx4B3Pfgw7cML6TsDX0NNpcAeLWfMIzpj/AQXFACO3E4D6P5Ez6AZRztaB8J/QdMG6gqAE1 3fXtzhJ/DSpnLyXDbBv5Q0IoRdm6AsDLfHbDohrkPmLTrxVTq+ozKTN2EZL/ueGMsn3jam0YdEA kAlBmLEA0Ub/xJd3xZFQfCiY= X-Received: by 127.0.0.2 with SMTP id 821GYY7687511xe9Z5kiNqOV; Mon, 13 Nov 2023 02:36:19 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.34129.1699871778453037872 for ; Mon, 13 Nov 2023 02:36:18 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-ezdKrwseMwWAyknab8kvsA-1; Mon, 13 Nov 2023 05:36:13 -0500 X-MC-Unique: ezdKrwseMwWAyknab8kvsA-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD6C9101A53B; Mon, 13 Nov 2023 10:36:12 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.194.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 778402026D66; Mon, 13 Nov 2023 10:36:12 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 37DAC1804A63; Mon, 13 Nov 2023 11:36:11 +0100 (CET) Date: Mon, 13 Nov 2023 11:36:11 +0100 From: "Gerd Hoffmann" To: xieyuanh Cc: devel@edk2.groups.io, Eric Dong , Ray Ni , Rahul Kumar Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Enable execute disable bit. Message-ID: References: <20231110103732.1399-1-yuanhao.xie@intel.com> MIME-Version: 1.0 In-Reply-To: <20231110103732.1399-1-yuanhao.xie@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: eVLjcI36al2f6RByz3dfnM5px7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KXx4B3Pf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > - GetProcessorNumber (CpuMpData, &ProcessorNumber); > - RestoreVolatileRegisters (&CpuMpData->CpuData[0].VolatileRegisters, FALSE); > - InterlockedIncrement ((UINT32 *)&CpuMpData->FinishedCount); > - PlaceAPInMwaitLoopOrRunLoop ( > - CpuMpData->ApLoopMode, > - CpuMpData->CpuData[ProcessorNumber].StartupApSignal, > - CpuMpData->ApTargetCState > - ); > - ApWakeupFunction (CpuMpData, ProcessorNumber); > + GetProcessorNumber(CpuMpData, &ProcessorNumber); > + InterlockedIncrement((UINT32 *)&CpuMpData->FinishedCount); You have some whitespace changes here makes the patch hard to read and I also doubt this will pass the uncrustify check in CI. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111131): https://edk2.groups.io/g/devel/message/111131 Mute This Topic: https://groups.io/mt/102504353/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-