public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, zhiguang.liu@intel.com
Cc: "Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
	 "Kumar, Rahul R" <rahul.r.kumar@intel.com>,
	"De, Debkumar" <debkumar.de@intel.com>,
	 "West, Catharine" <catharine.west@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: Support 5 level page table in ResetVector
Date: Fri, 14 Apr 2023 12:04:53 +0200	[thread overview]
Message-ID: <oys3alugmh5z6ovqc22cuxq3ax3rgiow3tvszjoy2md5zrummu@55ishqh4lflg> (raw)
In-Reply-To: <PH0PR11MB5048E2FCA19ABCB4E60C4BA090999@PH0PR11MB5048.namprd11.prod.outlook.com>

> Using 5level paging when the below two conditions are both true:
>   1. CPU support 5level paging
>   2. Platform choose to use 5level paging. (by specifing macro USE_5_LEVEL_PAGE_TABLE)
> 
> There is an assumption that if platform choose to use 5level paging,
> then 5level paging should be supported by CPU. (Platform should know
> its CPU capability)

That assumption does not hold for virtual machines.  OVMF builds with
5-level paging support enabled should continue to work on CPUs without
5-level paging support.

> If Platform choose to use 4level paging at build time, we can save 4K space by not creating the 5 level page.

I'm fine with that.

But with 5-level paging enabled the reset vector should be able to
fallback to 4-level paging in case the CPU does not support 5-level
paging.

take care,
  Gerd


  reply	other threads:[~2023-04-14 10:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03  9:28 [PATCH 2/2] UefiCpuPkg: Support 5 level page table in ResetVector Zhiguang Liu
2023-04-03 11:55 ` Gerd Hoffmann
2023-04-14  7:09   ` [edk2-devel] " Zhiguang Liu
2023-04-14 10:04     ` Gerd Hoffmann [this message]
2023-04-15  5:02       ` Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=oys3alugmh5z6ovqc22cuxq3ax3rgiow3tvszjoy2md5zrummu@55ishqh4lflg \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox