Re: [edk2-devel] [PATCH 02/11] OvmfPkg: add ShellLibs.dsc.inc

["Gerd Hoffmann" <kraxel@redhat.com>]

> > Given that EnrollDefaultKeys depends on the shell to launch
> > I'm wondering whenever we should just change that and make the
> > EnrollDefaultKeys build depend on BUILD_SHELL
> 
> This certainly sounds justified. It's hard to imagine a use case where
> someone wanted an EnrollDefaultKeys.efi binary, but not a fresh shell.efi.
> 
> > (and also move it into Shell*.inc) ?
> 
> Seems to make sense, technically speaking; it's again the naming that
> annoys me a bit. :( It's a utility that's supposed to be run from under
> the shell, but not related to the shell itself. Hmm. :/
> 
> I guess we can live with it.

We can certainly try to find a better name.
How about Applications*.inc?

In that case it'll probably make sense to also move UiApp.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114697): https://edk2.groups.io/g/devel/message/114697
Mute This Topic: https://groups.io/mt/103935344/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-