From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bounce+27952+114697+7686176+12367111@groups.io> Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7C08BAC1312 for <rebecca@openfw.io>; Mon, 29 Jan 2024 12:25:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=63zhPe0ML0V+C4TkG+lPKYu9/i+P2g7WRMFU40Icv4o=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706531154; v=1; b=WFdel12f9WwpFRPpV3xftz4fxwOLhviOZjG1qaxmX9PyK7jE190UFjCMnnqTorzmRTimjUre u0yFKjIfAMuyva7mJ0gpKhJUKd4F3Jm0yOmx+beibFvRAtIJz2meB3lzPJWhSPP3RV4xXRfuXdy NCrVsdM8QmuUwbF2bkn2SIGY= X-Received: by 127.0.0.2 with SMTP id WxnHYY7687511xHxgkSVvwQd; Mon, 29 Jan 2024 04:25:54 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.13201.1706531153487755429 for <devel@edk2.groups.io>; Mon, 29 Jan 2024 04:25:53 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-nsDDpO5vMbe2d3algZ1yQg-1; Mon, 29 Jan 2024 07:25:49 -0500 X-MC-Unique: nsDDpO5vMbe2d3algZ1yQg-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2E6C6862F7A; Mon, 29 Jan 2024 12:25:49 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D92FE2166B31; Mon, 29 Jan 2024 12:25:48 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 869E7180038B; Mon, 29 Jan 2024 13:25:47 +0100 (CET) Date: Mon, 29 Jan 2024 13:25:47 +0100 From: "Gerd Hoffmann" <kraxel@redhat.com> To: Laszlo Ersek <lersek@redhat.com> Cc: devel@edk2.groups.io, Jiewen Yao <jiewen.yao@intel.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, Michael Roth <michael.roth@amd.com>, Erdem Aktas <erdemaktas@google.com>, Min Xu <min.m.xu@intel.com>, Tom Lendacky <thomas.lendacky@amd.com>, Oliver Steffen <osteffen@redhat.com> Subject: Re: [edk2-devel] [PATCH 02/11] OvmfPkg: add ShellLibs.dsc.inc Message-ID: <p7iwe3tqqoj7ln3jqqlfsgqvm42cuftr2qxasdknbwqfj5vudq@in6sswalo4vl> References: <20240124163802.2160303-1-kraxel@redhat.com> <20240124163802.2160303-3-kraxel@redhat.com> <53e77c3c-86ad-b3fb-9474-0a4a7cdcb80f@redhat.com> <jvb4jkcodg24toexn4z6wzo4u7nxc2btdl53szgl2xu6qeebre@wbxfmsrdqvqe> <0e3aed3d-f1a5-e400-01bf-26c87445089f@redhat.com> MIME-Version: 1.0 In-Reply-To: <0e3aed3d-f1a5-e400-01bf-26c87445089f@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: <mailto:devel+subscribe@edk2.groups.io> List-Help: <mailto:devel+help@edk2.groups.io> Sender: devel@edk2.groups.io List-Id: <devel.edk2.groups.io> Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: <https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/plugh> X-Gm-Message-State: 5dENDVcW9TuHrNQ7dvIQVg3Px7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WFdel12f; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > > Given that EnrollDefaultKeys depends on the shell to launch > > I'm wondering whenever we should just change that and make the > > EnrollDefaultKeys build depend on BUILD_SHELL > > This certainly sounds justified. It's hard to imagine a use case where > someone wanted an EnrollDefaultKeys.efi binary, but not a fresh shell.efi. > > > (and also move it into Shell*.inc) ? > > Seems to make sense, technically speaking; it's again the naming that > annoys me a bit. :( It's a utility that's supposed to be run from under > the shell, but not related to the shell itself. Hmm. :/ > > I guess we can live with it. We can certainly try to find a better name. How about Applications*.inc? In that case it'll probably make sense to also move UiApp. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114697): https://edk2.groups.io/g/devel/message/114697 Mute This Topic: https://groups.io/mt/103935344/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-