Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait

["Gerd Hoffmann" <kraxel@redhat.com>]

  Hi,

> >   (3) Cache the measured data somewhere if needed multiple times
> >       (or simply cache unconditionally).
> > 
> Yes, agree.
> Cache the measured data into HOB in the PEI phase 
> and cache the measured data into the global variables in the DXE phase.
> How about this?

Load, measure and cache all fw_cfg entries we care about early in the
PEI phase (or SEC phase for pei-less builds), so we can
 (a) easily have a fixed order, and
 (b) store them all in HOBs?

Which implies SEC/PEI must read all relevant fw_cfg entries, even in
case they are used only later in the DXE phase.

Advantage is we have a single cache which can be used in all firmware
phases.  When using global variables in DXE we still can end up reading
entries multiple times, either because entries are needed by both PEI
and DXE, or because multiple DXE modules need them (global variables are
per module).

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116734): https://edk2.groups.io/g/devel/message/116734
Mute This Topic: https://groups.io/mt/104880546/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-