From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0C94A94147E for ; Thu, 14 Mar 2024 09:30:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rnm2yuKXDlF0mO4+7CiLDygcq54Cz5t7T8CYbVI3UAA=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1710408646; v=1; b=4JJGNytu2f7YbwaHbwybcUOJ1/81ews0QWQi7Sd+Iz84cG3jrGJF8C1pDcxFnNHK+A1EIuXX M0qlTW1zOUW3yj6rjCtiW8hYQIYsdtByJugDyWFjkK8OXLHISaVGxwop9jFRtrugqhuoaNbcz0P A1X3/YbbSgF0ec5qXBUHJWfN4cf+c11ndSfxiMlADH6Vpahe8qFmruFnzsttF7ELdxLFXoASqyH 9yZzihYzOljTbeQ1XTmLF8QWCQyeTyldoEcOr5h2UZ2AY50SqR9U/PMz8njUjm+8dlO+HLIasR5 voSCsVKOzQa91uJBkKaYZvAwNbQ4/z6+yi/Kiia1Odmqg== X-Received: by 127.0.0.2 with SMTP id 7PWOYY7687511xGl1UIbaoWb; Thu, 14 Mar 2024 02:30:46 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.8584.1710408645747587456 for ; Thu, 14 Mar 2024 02:30:45 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-sBlauULIOIyi5YrGgmguRw-1; Thu, 14 Mar 2024 05:30:37 -0400 X-MC-Unique: sBlauULIOIyi5YrGgmguRw-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3E8AD81A265; Thu, 14 Mar 2024 09:30:37 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7131111E404; Thu, 14 Mar 2024 09:30:36 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DDBE91800629; Thu, 14 Mar 2024 10:30:35 +0100 (CET) Date: Thu, 14 Mar 2024 10:30:35 +0100 From: "Gerd Hoffmann" To: "Sun, CepingX" Cc: "devel@edk2.groups.io" , "Aktas, Erdem" , "Yao, Jiewen" , "Xu, Min M" , "Reshetova, Elena" Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait Message-ID: References: <20240312235146.3777997-1-cepingx.sun@intel.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 14 Mar 2024 02:30:45 -0700 Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HMAKu0oAX6OkHNNyvz0XwtNex7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=4JJGNytu; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > > (3) Cache the measured data somewhere if needed multiple times > > (or simply cache unconditionally). > > > Yes, agree. > Cache the measured data into HOB in the PEI phase > and cache the measured data into the global variables in the DXE phase. > How about this? Load, measure and cache all fw_cfg entries we care about early in the PEI phase (or SEC phase for pei-less builds), so we can (a) easily have a fixed order, and (b) store them all in HOBs? Which implies SEC/PEI must read all relevant fw_cfg entries, even in case they are used only later in the DXE phase. Advantage is we have a single cache which can be used in all firmware phases. When using global variables in DXE we still can end up reading entries multiple times, either because entries are needed by both PEI and DXE, or because multiple DXE modules need them (global variables are per module). take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116734): https://edk2.groups.io/g/devel/message/116734 Mute This Topic: https://groups.io/mt/104880546/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-