From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F32D5941359 for ; Wed, 28 Feb 2024 08:22:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xlNu5S5I2bh7Zs+Y49gQFWq8IGMIvBrO2WZ0jmPnJxU=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1709108538; v=1; b=uefdeBggRjcgWLEqlsZSDw08XI4SwMHRXVhxLroti5QH7SuubXrSF5EO6jqqgdrB7czz1v9o Uyh4R1az5D/XmGDKZArmHDY5WHvkTR0LCvot5wnPCrRoubB+Fv/E16912X61qCFoMNbOXXbQJDV nVPIF/a48C4j/G3msIznfUxg= X-Received: by 127.0.0.2 with SMTP id UFIcYY7687511xgvt0ysiEY5; Wed, 28 Feb 2024 00:22:18 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.8971.1709108537856047880 for ; Wed, 28 Feb 2024 00:22:18 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-lTwfSCCZN6SlCV64kPdh7Q-1; Wed, 28 Feb 2024 03:22:13 -0500 X-MC-Unique: lTwfSCCZN6SlCV64kPdh7Q-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DAE701C05AC4; Wed, 28 Feb 2024 08:22:12 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8925E180C; Wed, 28 Feb 2024 08:22:12 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 592901801480; Wed, 28 Feb 2024 09:22:11 +0100 (CET) Date: Wed, 28 Feb 2024 09:22:11 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Tom Lendacky , Jiewen Yao , Oliver Steffen , Erdem Aktas , Michael Roth , Ard Biesheuvel , Min Xu Subject: Re: [edk2-devel] [PATCH 02/10] OvmfPkg/ResetVector: add ClearOvmfPageTables macro Message-ID: References: <20240222115435.85794-1-kraxel@redhat.com> <20240222115435.85794-3-kraxel@redhat.com> <453c3b30-8ab5-c258-d411-cf108761fd18@redhat.com> MIME-Version: 1.0 In-Reply-To: <453c3b30-8ab5-c258-d411-cf108761fd18@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0CL7KgqGNYkZQTY4ObvsPH1bx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=uefdeBgg; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Feb 28, 2024 at 05:09:32AM +0100, Laszlo Ersek wrote: > On 2/22/24 12:54, Gerd Hoffmann wrote: > > Move code to clear the page tables to a nasm macro. > > No functional change. > > > > Signed-off-by: Gerd Hoffmann > > --- > > OvmfPkg/ResetVector/Ia32/PageTables64.asm | 35 ++++++++++++----------- > > 1 file changed, 19 insertions(+), 16 deletions(-) > > > > diff --git a/OvmfPkg/ResetVector/Ia32/PageTables64.asm b/OvmfPkg/ResetVector/Ia32/PageTables64.asm > > index 6fec6f2beeea..378ba2feeb4f 100644 > > --- a/OvmfPkg/ResetVector/Ia32/PageTables64.asm > > +++ b/OvmfPkg/ResetVector/Ia32/PageTables64.asm > > @@ -45,6 +45,24 @@ BITS 32 > > %define TDX_BSP 1 > > %define TDX_AP 2 > > > > +; > > +; For OVMF, build some initial page tables at > > +; PcdOvmfSecPageTablesBase - (PcdOvmfSecPageTablesBase + 0x6000). > > +; > > +; This range should match with PcdOvmfSecPageTablesSize which is > > +; declared in the FDF files. > > +; > > +; At the end of PEI, the pages tables will be rebuilt into a > > +; more permanent location by DxeIpl. > > +; > > +%macro ClearOvmfPageTables 0 > > + mov ecx, 6 * 0x1000 / 4 > > + xor eax, eax > > +.clearPageTablesMemoryLoop: > > + mov dword[ecx * 4 + PT_ADDR (0) - 4], eax > > + loop .clearPageTablesMemoryLoop > > +%endmacro > > + > > ; > > ; Modified: EAX, EBX, ECX, EDX > > ; > > Ah, this made me read up on local labels: > > https://www.nasm.us/xdoc/2.16.01/html/nasmdoc3.html#section-3.9 > > Should we rather call the label > > ..@clearPageTablesMemoryLoop > > ? I've tried that and something (which I don't remember) didn't work as expected. Given that each branch which uses that macro will have a jump label anyway (so the local label is expanded to something like TdxBspInit.clearPageTablesMemoryLoop) I've figured this is good enough take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116094): https://edk2.groups.io/g/devel/message/116094 Mute This Topic: https://groups.io/mt/104506789/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-