From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A953774003B for ; Mon, 19 Feb 2024 10:21:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Zxy8moRRWsfj+LiTSxLAWrO1poghPzNvwlPMyGQ11uE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1708338097; v=1; b=paAin0IPIEviwyoPVk3IlPegf/wjRI2NYgpmsL7pVj9qQ93IMiAC8JiZv79Y1yzwJAU1Gfwa lK03L8If8sN+l/R+e9l7Y5w0a5izuR25mDnCdOei/XuGfSoxpQGMuFOL6eE4g2afC4Ux7lfEM4f 1FKDg+zUBmL5559J2MxvKTrI= X-Received: by 127.0.0.2 with SMTP id fHK8YY7687511xf7b41qC7Cm; Mon, 19 Feb 2024 02:21:37 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.38641.1708338096333572890 for ; Mon, 19 Feb 2024 02:21:36 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-qcTyXthJPzy3qccID2NxTQ-1; Mon, 19 Feb 2024 05:21:27 -0500 X-MC-Unique: qcTyXthJPzy3qccID2NxTQ-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3FB23185A780; Mon, 19 Feb 2024 10:21:27 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.175]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 04F1A492B0E; Mon, 19 Feb 2024 10:21:27 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 03F4F1800DCF; Mon, 19 Feb 2024 11:21:26 +0100 (CET) Date: Mon, 19 Feb 2024 11:21:25 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Jiewen Yao , Min Xu , Tom Lendacky , Oliver Steffen , Erdem Aktas , Ard Biesheuvel , Michael Roth Subject: Re: [edk2-devel] [PATCH v2 12/12] OvmfPkg: only add shell to FV in case secure boot is disabled Message-ID: References: <20240215102503.273275-1-kraxel@redhat.com> <20240215102503.273275-13-kraxel@redhat.com> <781606c6-b15e-525b-7deb-364af8c1fc9c@redhat.com> MIME-Version: 1.0 In-Reply-To: <781606c6-b15e-525b-7deb-364af8c1fc9c@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QXS5DeIWFBnlAzxEl1RX4zLDx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=paAin0IP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > > -!if $(BUILD_SHELL) == TRUE > > +!if $(BUILD_SHELL) == TRUE && $(SECURE_BOOT_ENABLE) == FALSE > > > > !if $(TOOL_CHAIN_TAG) != "XCODE5" > > !if $(NETWORK_ENABLE) == TRUE > > This does the job: > > Reviewed-by: Laszlo Ersek > > An alternative could be (perhaps informing the user better): > > !if $(BUILD_SHELL) == TRUE > !if $(SECURE_BOOT_ENABLE) == TRUE > !error BUILD_SHELL and SECURE_BOOT_ENABLE conflict > !endif > ... > !endif That would break CI. Patch 11/12 depends on the shell being built even if not included in the firmware image, so it can be copied to the virtual drive used by the qemu test. > A repost might be worth your while either way, because some of the > patches are identical to their first versions, and Jiewen's v1 Acked-by, > from [1], is missing from the unchanged (or trivially rebased) patches > in v2. Oops, right, went over all individual patches updating them, then forgot the Jiewen's ack for the whole series. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115589): https://edk2.groups.io/g/devel/message/115589 Mute This Topic: https://groups.io/mt/104370218/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-