From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8477AD811B1 for ; Thu, 14 Mar 2024 10:59:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=evJQpuNtYUFdHK2vFWZa4KWCoNKZQwbwFrbRSHNIGmc=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1710413973; v=1; b=LRXZjZ60Nfozf6kqK5q956HEdSGp8w6TuIKIb0CzICH3r0gPQ2vOpwqzvhnhShDxQkt1/wuD Y5wULHsZ2OGgqtwx7MuaTACEHvHT9nEPThQp2FtxRtPQJsmTHPtipd/fncwbHl2pCLH71sNbmS7 xg/sWj37jbe3ZqXXcdQPiZ57gCBuRm93yrJFL5ecDmCUAcKwdC6JHgu7X1ecdzYUMX6JtNDFAYx /4n2r7erhxl+6KJyzsVZhMItuOy7Tw4YVsgWGsDGSiFtaaKJl21gRWc/UPA8LBdJgRDAtGwSlXs m4QOQyDx7Cw6LuO4S+zX8x2zNOYOCzW0JNWtDARapJzzA== X-Received: by 127.0.0.2 with SMTP id XwaFYY7687511xMMdVOe6qwE; Thu, 14 Mar 2024 03:59:33 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.9746.1710413972368580759 for ; Thu, 14 Mar 2024 03:59:32 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-523Oly_lOOCNYAPEl-475g-1; Thu, 14 Mar 2024 06:59:29 -0400 X-MC-Unique: 523Oly_lOOCNYAPEl-475g-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47DB03C02530; Thu, 14 Mar 2024 10:59:29 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C83B72166AE8; Thu, 14 Mar 2024 10:59:28 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id B670C1800629; Thu, 14 Mar 2024 11:59:27 +0100 (CET) Date: Thu, 14 Mar 2024 11:59:27 +0100 From: "Gerd Hoffmann" To: Chao Li Cc: devel@edk2.groups.io, Ray Ni , Rahul Kumar Subject: Re: [edk2-devel] [PATCH v1 05/26] UefiCpuPkg: Add LoongArch64 CPU Timer instance Message-ID: References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093752.1253486-1-lichao@loongson.cn> MIME-Version: 1.0 In-Reply-To: <20240311093752.1253486-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 14 Mar 2024 03:59:32 -0700 Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7xPyzMuRYXqGkw4kS6BJe8Cmx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=LRXZjZ60; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) Hi, > + if ((BaseFreq == 0x0) || (ClockMultiplier == 0x0) || (ClockDivide == 0x0)) { > + DEBUG (( > + DEBUG_ERROR, > + "LoongArch Stable Timer is not available in the CPU, hence this library cannot be used.\n" > + )); > + ASSERT (FALSE); > + CpuDeadLoop (); > + } > + > + StableTimerFreq = ((ClockMultiplier * BaseFreq) / ClockDivide); > + > + if (StableTimerFreq == 0x0) { > + ASSERT (FALSE); > + } If you don't want to log a message (as in the case above) you can simplify this to "ASSERT(StableTimerFreq != 0);" Additional benefit is that it'll give a more helpful log message. > + // > + // Ticks > + // Time = --------- x 1,000,000,000 > + // Frequency > + // > + Status = SafeUint64Mult ( > + DivU64x64Remainder (Ticks, Frequency, &Remainder), > + 1000000000u, > + &NanoSeconds > + ); Not checking Status here? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116745): https://edk2.groups.io/g/devel/message/116745 Mute This Topic: https://groups.io/mt/104859876/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-