From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 22813941405 for ; Wed, 20 Mar 2024 10:16:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7phc/k7yAyR/IGUqfg4dy5+R3ASR1LGL1YH3W3Z+CzA=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240206; t=1710929806; v=1; b=Da0mn2ar9TOn9fRex5GFD1aeq65YqrPQRotV/Otb44nJV7YQxlUArwbNOWrwssiGeb1fH0U7 bm0Y7BxLBUqLr1jK7Azu+HKF60lbn0ygOW6M/LT2TAN8T//DROUjiEPpsb0VerrDTN00REy0m6D pmHT0+alHgQWFwxDq4XQ4eGZ7hJHH3LggR6/qaf+uFOgdl6pusvh//fwZTE5ftjhu2iyWXAFp0x h8gCbBceWxY4UO1ZivqmtKAxR6EQaeCjhz+lkplsEgWsVJ0X9wlTImOQtYbO81WM27u9nTSVQNT YJYh2GEk+e1TPCE8UKNZ27a1Fl906ilyrO+QzA6j+/10w== X-Received: by 127.0.0.2 with SMTP id 5yAuYY7687511xENZWr81DSn; Wed, 20 Mar 2024 03:16:46 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.40288.1710929805578340256 for ; Wed, 20 Mar 2024 03:16:45 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-FXPsDHL5OliHiup5RaN9PA-1; Wed, 20 Mar 2024 06:16:39 -0400 X-MC-Unique: FXPsDHL5OliHiup5RaN9PA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5ACAB101A526; Wed, 20 Mar 2024 10:16:39 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D934B1121337; Wed, 20 Mar 2024 10:16:38 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 97A2F1800D4F; Wed, 20 Mar 2024 11:16:33 +0100 (CET) Date: Wed, 20 Mar 2024 11:16:33 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: lixianglai , lichao@loongson.cn, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian Subject: Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib Message-ID: References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093924.1254576-1-lichao@loongson.cn> <01d94c67-de3d-7709-84d4-ec97dc7a01ec@loongson.cn> <2teja7rxfli7fxvxlii54tbdaj2y6jz2qlvprf7pfpzzjyycrz@gp5axpziekwh> MIME-Version: 1.0 In-Reply-To: <2teja7rxfli7fxvxlii54tbdaj2y6jz2qlvprf7pfpzzjyycrz@gp5axpziekwh> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 20 Mar 2024 03:16:45 -0700 Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IilUi3TJmNHpwuM7w1bqy2UIx7686176AA= Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Da0mn2ar; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Mar 18, 2024 at 04:28:17PM +0100, Gerd Hoffmann wrote: > On Sat, Mar 16, 2024 at 10:17:00AM +0800, lixianglai wrote: > > Hi Gerd: > > > On Mon, Mar 11, 2024 at 02:39:31AM -0700, Chao Li wrote: > > >> This library for PEI phase, and obtains the QemuFwCfg base address by > > >> directly parsing the FDT, reads and writes the data in QemuFwCfg by > > >> operating on the QemuFwCfg base address. > > >> create mode 100644 OvmfPkg/LoongArchVirt/Library/FdtQemuFwCfgLib/FdtQemuFwCfgPeiLib.c > > >> create mode 100644 OvmfPkg/LoongArchVirt/Library/FdtQemuFwCfgLib/FdtQemuFwCfgPeiLib.inf > > >> create mode 100644 OvmfPkg/LoongArchVirt/Library/FdtQemuFwCfgLib/QemuFwCfgLibInternal.h > > >> create mode 100644 OvmfPkg/LoongArchVirt/Library/FdtQemuFwCfgLib/QemuFwCfgPei.c > > > Is there anything LoongArch-specific in there? > > No,The main function of this lib library is to obtain the fwcfg base address by parsing fdt in the pei stage, > >  and provide access to fwcfg through mmio mode, > >  the difference between it and the existing library is that the fwcfg base address is not hard-coded in the compilation stage, > >  and is accessed through mmio rather than io port. > > That would be the case for risc-v and aarch64 too, although I think they > don't need fw_cfg right now (they get all info needed via fdt). Oops, I was wrong, we have OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116933): https://edk2.groups.io/g/devel/message/116933 Mute This Topic: https://groups.io/mt/104859897/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-