From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 57536D811F1 for ; Wed, 17 Apr 2024 08:02:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tthLiUORt0yaEQuvK7Dc3S5Kz8AWuKXBBTQ2Sm1hWpE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240206; t=1713340922; v=1; b=N7KkYPFDBxJnJ23mbNzQn30lmHf4G7Hbp54wZe86joS/ip2A0MYkMHOIi97FQwVRbGNXpE0V D0W76fMFoTyeZOBudJ5WXIDJGP/zw8xEkQRV6NHLXh/oY7wl0HCIQgF3aSbUtW+BHBRl6OCixKW Fm8aGjFlEMzxzoy7LnC6KtXpvHktul5ModlevlDqEQgq6WOBO/rPI8Oq8psYJEg//K9EFMUhN90 Hv5bFGYgw1wmLBYuYuQXyuJ+7SpPZJgMjIv9zxN71MyqSvZvJkI0MvmxVH/F9GUq4VJ7bqiO4uE hP4jTqD29k7zWnLiQi5YaWcE320rXug0MAlIYtGnxsHpQ== X-Received: by 127.0.0.2 with SMTP id 3eqyYY7687511xrPTRraOUaH; Wed, 17 Apr 2024 01:02:02 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.7528.1713340922163633472 for ; Wed, 17 Apr 2024 01:02:02 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-y49cBMTlPjG-bZ7j4rbAXw-1; Wed, 17 Apr 2024 04:01:52 -0400 X-MC-Unique: y49cBMTlPjG-bZ7j4rbAXw-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E96C3801797; Wed, 17 Apr 2024 08:01:51 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.192.214]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83A9D40C6CC1; Wed, 17 Apr 2024 08:01:51 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id 1606FEE0BF; Wed, 17 Apr 2024 10:01:30 +0200 (CEST) Date: Wed, 17 Apr 2024 10:01:30 +0200 From: "Gerd Hoffmann" To: Chao Li Cc: devel@edk2.groups.io, lixianglai , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian Subject: Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib Message-ID: References: <01d94c67-de3d-7709-84d4-ec97dc7a01ec@loongson.cn> <2teja7rxfli7fxvxlii54tbdaj2y6jz2qlvprf7pfpzzjyycrz@gp5axpziekwh> <949717bb-5dbd-4298-9482-a3b12ded650a@loongson.cn> <17BEC74BB37915EC.2828@groups.io> <323033d0-8749-4885-a4b1-7f6f854b6487@loongson.cn> <5fjrgywtmvboqdi43n7brrzms67skc3zejzvnekz2v62znhzpk@wjidta4b7rae> <1a290eb4-543f-43cd-a8b2-337bb48b89ff@loongson.cn> MIME-Version: 1.0 In-Reply-To: <1a290eb4-543f-43cd-a8b2-337bb48b89ff@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 17 Apr 2024 01:02:02 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jzeYpEDVPtV7ukRZIqXfFnkYx7686176AA= Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=N7KkYPFD; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Wed, Apr 17, 2024 at 03:43:30PM +0800, Chao Li wrote: > Hi Gerd, > > > Thanks, > Chao > On 2024/4/17 14:59, Gerd Hoffmann wrote: > > On Wed, Apr 17, 2024 at 10:53:21AM +0800, Chao Li wrote: > > > Hi Gerd, > > > > > > Part 2 has been be merged, I'm separating  this Lib into two serve the PEI > > > stage and DXE stage. > > > > > > Currently, This DXE library uses three global variables, and when I simulate > > > the no-mmio version: MmioLib.c + Dxe.c + Pei.c, I can abstract some helper > > > functions as the public functions in Mmio version. > > > > > > Do you mind if I replace these three vaiables with three dynamically typed > > > PCDs? If so, the PEI and DXE stage libraries can using  some of the same > > > APIs. > > What is your idea? Let PEI discover fw_cfg, store results in PCDs, and > > DXE will read the PCDs instead of using FdtClientProtocol to find the > > fw_cfg? > > > > Note that risc-v and arm don't need access to fw_cfg in PEI, so this > > approach would not work for them. > > No no no, I mean these two stages have their own way to get the FDT > resouces, for example: PEI stage uses fdtlib to find the fw_cfg and the DXE > stage uses FdtClientProtocol to find the fw_cfg, DXE will look for fw_cfg > anyway. Ok. I'm wondering what the point of using PCDs is then. > Can I submit a patch set for quick review by you? It content only four > patches. Sure, maybe that is the easiest way to explain ;) take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117903): https://edk2.groups.io/g/devel/message/117903 Mute This Topic: https://groups.io/mt/104859897/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-