From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.100044.1679661042549257125 for ; Fri, 24 Mar 2023 05:30:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GwvpEg7U; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679661041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DMfYagysHQiVsBBFpm+xrOnv4xmDhNLHra8NLPaqygk=; b=GwvpEg7UYiK9cfnm0zT66ng4q2sXmjm578CIlaC2GV3RTvgeeM6DWDv1SVnJTJg8N28E5r GSB2fFjDJrKceJvqjvbxB9D6bT2rEFcyXHR+h22hyRp6sDZhxYNWTI/GWlxc15LgyFBKiP shmGaRp2B+3U85pk7hLJaszLqKPNyho= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-91-6WXK7iu7P12JVDvZtuPPIA-1; Fri, 24 Mar 2023 08:30:37 -0400 X-MC-Unique: 6WXK7iu7P12JVDvZtuPPIA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DEF16885626; Fri, 24 Mar 2023 12:30:36 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0E184020C83; Fri, 24 Mar 2023 12:30:36 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4002F1800084; Fri, 24 Mar 2023 13:30:35 +0100 (CET) Date: Fri, 24 Mar 2023 13:30:35 +0100 From: "Gerd Hoffmann" To: Jeff Brasen Cc: devel@edk2.groups.io, philmd@redhat.com, ardb+tianocore@kernel.org, jiewen.yao@intel.com, jordan.l.justen@intel.com Subject: Re: [PATCH] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAlignment. Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 24, 2023 at 01:42:17AM +0000, Jeff Brasen wrote: > Nothing to do here for virtio 1.0 devices > > Signed-off-by: Jeff Brasen > --- > .../Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > index 8bdf1e1fc3..de2c5fa2a6 100644 > --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > @@ -144,7 +144,9 @@ VirtioMmioSetQueueAlignment ( > > Device = VIRTIO_MMIO_DEVICE_FROM_VIRTIO_DEVICE (This); > > - VIRTIO_CFG_WRITE (Device, VIRTIO_MMIO_OFFSET_QUEUE_ALIGN, Alignment); > + if (Device->Version == VIRTIO_MMIO_DEVICE_VERSION_0_95) { > + VIRTIO_CFG_WRITE (Device, VIRTIO_MMIO_OFFSET_QUEUE_ALIGN, Alignment); > + } Reviewed-by: Gerd Hoffmann