From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EF5B97803D0 for ; Tue, 29 Aug 2023 11:17:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qt5xNG4Uww5+VRSKNXZIRJHA1HjKzzFaelnc+gmAIJE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1693307868; v=1; b=ieRr9lrPC1RY5P+aSvvd50Okbe7evMcV5jc1iGVNrgLu0wahI8VlXA70gg9L+FJGzDEq0FI7 P4FxC0A4SlD4b3J2I9SL9xZHE41gZEGSNPbX1Dv9hCo4wJYJfS0CISVGAwlLBdtGKIsNi8+eBFj M3tjumurpeDY1WwxYmReJX8g= X-Received: by 127.0.0.2 with SMTP id SdVSYY7687511xQIjivo4OLb; Tue, 29 Aug 2023 04:17:48 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.14918.1693307867774856046 for ; Tue, 29 Aug 2023 04:17:47 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-427-3fY4Tur0Nra3uAaqtJ9ELg-1; Tue, 29 Aug 2023 07:17:43 -0400 X-MC-Unique: 3fY4Tur0Nra3uAaqtJ9ELg-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A93CA185A791; Tue, 29 Aug 2023 11:17:42 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F4CD40C6F4C; Tue, 29 Aug 2023 11:17:42 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id F0E6E180093B; Tue, 29 Aug 2023 13:17:40 +0200 (CEST) Date: Tue, 29 Aug 2023 13:17:40 +0200 From: "Gerd Hoffmann" To: Taylor Beebe Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Rebecca Cran , Peter Grehan , Corvin =?utf-8?B?S8O2aG5l?= Subject: Re: [edk2-devel] [PATCH v2 20/25] OvmfPkg: Enable Choosing Memory Protection Profile via QemuCfg Message-ID: References: <20230818223159.1073-1-taylor.d.beebe@gmail.com> <20230818223159.1073-21-taylor.d.beebe@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230818223159.1073-21-taylor.d.beebe@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HzkfnEVxwSTJgiNbd59oftUCx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ieRr9lrP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > - SetDxeMemoryProtectionSettings (&DxeSettings, DxeMemoryProtectionSettingsPcd); > - SetMmMemoryProtectionSettings (&MmSettings, MmMemoryProtectionSettingsPcd); > + Status = QemuFwCfgParseString (DXE_MEMORY_PROTECTION_PROFILE_FWCFG_FILE, &StringSize, String); > + if (!EFI_ERROR (Status)) { > + DEBUG ((DEBUG_INFO, "Setting DXE Memory Protection Profile: %a\n", String)); > + if (AsciiStriCmp (String, "debug") == 0) { > + DxeSettings = DxeMemoryProtectionProfiles[DxeMemoryProtectionSettingsDebug].Settings; I'd suggest to just loop over DxeMemoryProtectionProfiles and compare String with .Name, so we don't have to touch this in case we add or remove profiles. > + DxeSettings = DxeMemoryProtectionProfiles[DxeMemoryProtectionSettingsDebug].Settings; I'd prefer to use DxeMemoryProtectionSettingsPcd by default. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108089): https://edk2.groups.io/g/devel/message/108089 Mute This Topic: https://groups.io/mt/100830924/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-