From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3400F7803CD for ; Wed, 21 Feb 2024 10:24:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7n6Lrl77oXPWdoDnapSlJO8MGZvubAlZI6azAswyaj4=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1708511092; v=1; b=YIol3YO/4SOT5OEQo5fKLNIXA5SuX5Cp64QkPWOFNsOCsUayTUML3AXnid2Yro2G+hAWyOtD 0VoLk/A7IHI0Shlmh9AXA4xzPVg7etBSSMHn806fzp5SXiJSXeF32hvG6FJSXQG1oKlUVk7P29i 3QguoZ9q3y0KwlfBRLL7pglo= X-Received: by 127.0.0.2 with SMTP id s4ZSYY7687511xKv8kWvhyvV; Wed, 21 Feb 2024 02:24:52 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.9927.1708511091875086310 for ; Wed, 21 Feb 2024 02:24:52 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-Ha12fKsjPpaIOU7CjnXaQg-1; Wed, 21 Feb 2024 05:24:49 -0500 X-MC-Unique: Ha12fKsjPpaIOU7CjnXaQg-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 37561185A782; Wed, 21 Feb 2024 10:24:49 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12F33492BD7; Wed, 21 Feb 2024 10:24:49 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DDD211800DDB; Wed, 21 Feb 2024 11:24:47 +0100 (CET) Date: Wed, 21 Feb 2024 11:24:47 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, ray.ni@intel.com Cc: Oliver Steffen , Laszlo Ersek , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v2 5/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData() Message-ID: References: <20240220174939.1288689-1-kraxel@redhat.com> <20240220174939.1288689-6-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: auzkEqN3ISMGeA2Et6CD74jXx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="YIol3YO/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Feb 21, 2024 at 03:48:25AM +0000, Ni, Ray wrote: > > > > + MaxCpusPerHob = (MAX_UINT16 - sizeof (EFI_HOB_GUID_TYPE) - sizeof > > (MP_HAND_OFF)) / sizeof (PROCESSOR_HAND_OFF); > > Above formula assumes the maximum HOB length could be 0xFFFF. Which is IMHO correct. > But actually the maximum HOB length could be only 0xFFF8 because > PeiCore::PeiCreateHob() contains following logic: > > if (0x10000 - Length <= 0x7) { > return EFI_INVALID_PARAMETER; > } That Length is the *data* size, the HOB header is not included. The "- sizeof (EFI_HOB_GUID_TYPE)" in the formula above accounts the space needed for HOB header and GUID. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115723): https://edk2.groups.io/g/devel/message/115723 Mute This Topic: https://groups.io/mt/104472313/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-