From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.6455.1687253584453495101 for ; Tue, 20 Jun 2023 02:33:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=d8S7r3kw; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687253583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YpijJIi6W/Q9khk0Lhw/aCTi2F47XRa4FK5AuTJQQX8=; b=d8S7r3kwnxZRn+h0U/MVilQfVAu/aXmMt9GHLLvz/0cvKObOIThDrQd7LoVHzKLJH5qnoK hBObmLRLgB0eD1kOgS15hhr7pe8zrq7dVTfPi5Wag7sfKGsjLvhAU6PGGpGm3i9tj7ttcM gQS+7dvoOQySF2RXFYV4pBeGap7K8rI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-JdDroc5KO7iufMes0pVuyw-1; Tue, 20 Jun 2023 05:32:58 -0400 X-MC-Unique: JdDroc5KO7iufMes0pVuyw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7957B185A792; Tue, 20 Jun 2023 09:32:57 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC714492B01; Tue, 20 Jun 2023 09:32:56 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6FC721803082; Tue, 20 Jun 2023 11:32:55 +0200 (CEST) Date: Tue, 20 Jun 2023 11:32:55 +0200 From: "Gerd Hoffmann" To: Oliver Steffen Cc: devel@edk2.groups.io, Ard Biesheuvel , Daniel Schaefer , Eric Dong , Leif Lindholm , Liming Gao , Michael D Kinney , Rahul Kumar , Ray Ni , Sami Mujawar , Sunil V L , Zhiguang Liu Subject: Re: [PATCH 1/1] ArmPkg: Add Pcd to disable EFI_MEMORY_ATTRIBUTE_PROTOCOL Message-ID: References: <20230619203244.228933-1-osteffen@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230619203244.228933-1-osteffen@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 19, 2023 at 10:32:25PM +0200, Oliver Steffen wrote: > Recent versions of shim (15.6 and 15.7) crash when the newly added > EFI_MEMORY_ATTRIBUTE_PROTOCOL is provided by the firmware. To allow > existing installations to boot, provide a workaround in form of a Pcd > that allows tuning it off at build time (defaults to 'enabled'). Background: We have untested + broken code for EFI_MEMORY_ATTRIBUTE_PROTOCOL support in the listed shim releases. Now that firmware starts to actually provide that protocol the time bomb explodes. > --- a/ArmPkg/ArmPkg.dec > +++ b/ArmPkg/ArmPkg.dec > @@ -172,6 +172,9 @@ [PcdsFixedAtBuild.common] > gArmTokenSpaceGuid.PcdCpuVectorBaseAddress|0xffff0000|UINT64|0x00000004 > gArmTokenSpaceGuid.PcdCpuResetAddress|0x00000000|UINT32|0x00000005 > > + # Enable/Disable EFI_MEMORY_ATTRIBUTE_PROTOCOL > + gArmTokenSpaceGuid.PcdEnableEfiMemoryAttributeProtocol|TRUE|BOOLEAN|0x000000EE > + > # > # ARM Secure Firmware PCDs > # Given that I expect we will run into the very same problem on x64 as soon as EFI_MEMORY_ATTRIBUTE_PROTOCOL gets enabled there we should probably define the PCD in MdePkg not ArmPkg (which implies splitting the patch into a mini series with one MdePkg and one ArmPkg patch). take care, Gerd