public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@google.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb@kernel.org>,
	 Laszlo Ersek <lersek@redhat.com>,
	Oliver Steffen <osteffen@redhat.com>,
	 Alexander Graf <graf@amazon.com>,
	Oliver Smith-Denny <osde@linux.microsoft.com>,
	 Taylor Beebe <taylor.d.beebe@gmail.com>,
	Peter Jones <pjones@redhat.com>,
	 Leif Lindholm <quic_llindhol@quicinc.com>
Subject: Re: [edk2-devel] [PATCH v3] ArmVirt: Allow memory attributes protocol to be disabled
Date: Mon, 11 Dec 2023 11:55:55 +0100	[thread overview]
Message-ID: <rp4sly3phw2wzd6dbzrihrxjjmjgr2utxptbkvfft3o36k7vix@3xhxe7qhugh3> (raw)
In-Reply-To: <20231211104024.185070-1-ardb@google.com>

> +  //
> +  // Work around shim's terminally broken use of the EFI memory attributes
> +  // protocol, by uninstalling it if requested on the QEMU command line.
> +  //
> +  // E.g.,
> +  //       -fw_cfg opt/org.tianocore/UninstallMemAttrProtocol,string=y
> +  //
> +  // This is only needed on the first boot, when fbaa64.efi is being invoked to
> +  // set the boot order variables. Subsequent boots involving GRUB are not
> +  // affected.
> +  //
> +  Uninstall = FixedPcdGetBool (PcdUninstallMemAttrProtocol);
> +  QemuFwCfgParseBool ("opt/org.tianocore/UninstallMemAttrProtocol", &Uninstall);
> +  if (Uninstall) {
> +    UninstallEfiMemoryAttributesProtocol ();
> +  }

Can we please have a log message here, for both uninstall and
keep-installed cases?

Otherwise the patch looks good to me.

thanks,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112290): https://edk2.groups.io/g/devel/message/112290
Mute This Topic: https://groups.io/mt/103106391/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-12-11 10:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 10:40 [edk2-devel] [PATCH v3] ArmVirt: Allow memory attributes protocol to be disabled Ard Biesheuvel
2023-12-11 10:55 ` Gerd Hoffmann [this message]
2023-12-11 14:31   ` Laszlo Ersek
2023-12-11 14:44     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=rp4sly3phw2wzd6dbzrihrxjjmjgr2utxptbkvfft3o36k7vix@3xhxe7qhugh3 \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox