From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A8BE5941523 for ; Mon, 11 Dec 2023 10:56:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+xgqUvjkh9p3zr6+LaDu4ck0d3MNFXI+4yoPiZ8GUo8=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1702292166; v=1; b=Rj2Qs6bZHCGLUQpGftJ4xKSTfJwsuUMS7cU4dMDQzWE5abXro41tphW8amQTDGbQDSxWGF1/ qEhU8XGI/Zu5QW+MqCnKGVrQOqEW/DNoJJPscs5KNu2Wv93Z9NiyOPsNUbg19G4exmiF2An4Air 5D6mwOKiQ8W5dS5ddc57Mho0= X-Received: by 127.0.0.2 with SMTP id 6SawYY7687511xhBXTSh9X1Y; Mon, 11 Dec 2023 02:56:06 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.5869.1702292165675188990 for ; Mon, 11 Dec 2023 02:56:05 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-GGRHRUmHOn2Xk-Pl9e73eg-1; Mon, 11 Dec 2023 05:56:02 -0500 X-MC-Unique: GGRHRUmHOn2Xk-Pl9e73eg-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0452C3CBE327; Mon, 11 Dec 2023 10:56:02 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0F3E3C2E; Mon, 11 Dec 2023 10:56:01 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 3E007180039F; Mon, 11 Dec 2023 11:55:55 +0100 (CET) Date: Mon, 11 Dec 2023 11:55:55 +0100 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Ard Biesheuvel , Laszlo Ersek , Oliver Steffen , Alexander Graf , Oliver Smith-Denny , Taylor Beebe , Peter Jones , Leif Lindholm Subject: Re: [edk2-devel] [PATCH v3] ArmVirt: Allow memory attributes protocol to be disabled Message-ID: References: <20231211104024.185070-1-ardb@google.com> MIME-Version: 1.0 In-Reply-To: <20231211104024.185070-1-ardb@google.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vZCJuxabA0Hgl3lZ6bCGkt5Vx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Rj2Qs6bZ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > + // > + // Work around shim's terminally broken use of the EFI memory attributes > + // protocol, by uninstalling it if requested on the QEMU command line. > + // > + // E.g., > + // -fw_cfg opt/org.tianocore/UninstallMemAttrProtocol,string=y > + // > + // This is only needed on the first boot, when fbaa64.efi is being invoked to > + // set the boot order variables. Subsequent boots involving GRUB are not > + // affected. > + // > + Uninstall = FixedPcdGetBool (PcdUninstallMemAttrProtocol); > + QemuFwCfgParseBool ("opt/org.tianocore/UninstallMemAttrProtocol", &Uninstall); > + if (Uninstall) { > + UninstallEfiMemoryAttributesProtocol (); > + } Can we please have a log message here, for both uninstall and keep-installed cases? Otherwise the patch looks good to me. thanks, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112290): https://edk2.groups.io/g/devel/message/112290 Mute This Topic: https://groups.io/mt/103106391/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-