Re: [edk2-devel] [PATCH 07/16] OvmfPkg/CcExitLib: Add support for the SVSM_CORE_PVALIDATE call

["Gerd Hoffmann" <kraxel@redhat.com>]

> -/**
> - This function issues the PVALIDATE instruction to validate or invalidate the memory
> - range specified. If PVALIDATE returns size mismatch then it retry validating with
> - smaller page size.
> -
> - */
> -STATIC
> -VOID
> -PvalidateRange (
> -  IN  SNP_PAGE_STATE_CHANGE_INFO  *Info
> -  )

> --- a/OvmfPkg/Library/CcExitLib/CcExitSvsm.c
> +++ b/OvmfPkg/Library/CcExitLib/CcExitSvsm.c

> +#define PAGES_PER_2MB_ENTRY  512

> +SvsmTerminate (
> +SvsmGetCaa (
> +SvsmMsrProtocol (

Adding these three funcions can go to a separate patch.

> +SvsmPvalidate (

> +        GfnEnd = Gfn + 511;

Use PAGES_PER_2MB_ENTRY here?

> +BasePvalidate (
> +  IN SNP_PAGE_STATE_CHANGE_INFO  *Info
> +  )

So you rename PvalidateRange() to BasePvalidate() and move it to this
place.  Moving code without functional change should be done as separate
patch.

Also I'm wondering why you move the vmpl0 version of the function (which
does *not* call into the SVSM) into the CcExitSvsm.c file.  The old
place looks like a better fit to me.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114706): https://edk2.groups.io/g/devel/message/114706
Mute This Topic: https://groups.io/mt/103986455/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-