From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BC3F8740034 for ; Mon, 29 Jan 2024 14:41:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Tfy6hE/AYV9XNyrge/QK7QFdklIwTEUO/mnkYsR72lM=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706539269; v=1; b=Yq2r9doTwdlzvcVMWboV/7YQ1lzNy8k6knmWlAUW9I3cYNYS4sk2Egs7hJN8sI/9ewB+vt8c w87t2JEBCFZjNswiwWnxVBo9X0WRIlMMPhvip9fO7Gwfaoxmuh0DA9O1oHT8nvZ+hmsWSKCdrD7 3FXI93xZE8XpJvu2/uIkKuAs= X-Received: by 127.0.0.2 with SMTP id QLrTYY7687511x8TyBdw9MZA; Mon, 29 Jan 2024 06:41:09 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.16453.1706539268594054297 for ; Mon, 29 Jan 2024 06:41:08 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-xlsp7sOKMSuSel1WjjI4tg-1; Mon, 29 Jan 2024 09:41:01 -0500 X-MC-Unique: xlsp7sOKMSuSel1WjjI4tg-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A9FD7185A787; Mon, 29 Jan 2024 14:41:00 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B67F9AD4; Mon, 29 Jan 2024 14:40:59 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6E271180038B; Mon, 29 Jan 2024 15:40:58 +0100 (CET) Date: Mon, 29 Jan 2024 15:40:58 +0100 From: "Gerd Hoffmann" To: Tom Lendacky Cc: devel@edk2.groups.io, Ard Biesheuvel , Erdem Aktas , Jiewen Yao , Laszlo Ersek , Liming Gao , Michael D Kinney , Min Xu , Zhiguang Liu , Rahul Kumar , Ray Ni , Michael Roth Subject: Re: [edk2-devel] [PATCH 07/16] OvmfPkg/CcExitLib: Add support for the SVSM_CORE_PVALIDATE call Message-ID: References: <7bd1171077a547173d35f95a89387d13abdc8301.1706307195.git.thomas.lendacky@amd.com> MIME-Version: 1.0 In-Reply-To: <7bd1171077a547173d35f95a89387d13abdc8301.1706307195.git.thomas.lendacky@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MfCAReaOAbfI8F1yjYcyJUgFx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Yq2r9doT; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > -/** > - This function issues the PVALIDATE instruction to validate or invalidate the memory > - range specified. If PVALIDATE returns size mismatch then it retry validating with > - smaller page size. > - > - */ > -STATIC > -VOID > -PvalidateRange ( > - IN SNP_PAGE_STATE_CHANGE_INFO *Info > - ) > --- a/OvmfPkg/Library/CcExitLib/CcExitSvsm.c > +++ b/OvmfPkg/Library/CcExitLib/CcExitSvsm.c > +#define PAGES_PER_2MB_ENTRY 512 > +SvsmTerminate ( > +SvsmGetCaa ( > +SvsmMsrProtocol ( Adding these three funcions can go to a separate patch. > +SvsmPvalidate ( > + GfnEnd = Gfn + 511; Use PAGES_PER_2MB_ENTRY here? > +BasePvalidate ( > + IN SNP_PAGE_STATE_CHANGE_INFO *Info > + ) So you rename PvalidateRange() to BasePvalidate() and move it to this place. Moving code without functional change should be done as separate patch. Also I'm wondering why you move the vmpl0 version of the function (which does *not* call into the SVSM) into the CcExitSvsm.c file. The old place looks like a better fit to me. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114706): https://edk2.groups.io/g/devel/message/114706 Mute This Topic: https://groups.io/mt/103986455/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-