From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: "Xu, Min M" <min.m.xu@intel.com>, joeyli <jlee@suse.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest
Date: Tue, 11 Apr 2023 12:04:26 +0200 [thread overview]
Message-ID: <shlx36de2yoszmxy3wuapqsjek3uqtmg6xgqkw76ihstu2qysq@h5dabwczhcxk> (raw)
In-Reply-To: <7a06aa46-4c10-fc85-48a6-826a4d82991e@amd.com>
On Fri, Apr 07, 2023 at 12:00:46PM -0500, Tom Lendacky wrote:
>
> Thanks for the quick turn-around, but that patch didn't work for me. I've
> update the bugzilla.
Can you try the patch below?
thanks,
Gerd
>From a9179864523d12c3dcc137f36f6ed1a2832ed22c Mon Sep 17 00:00:00 2001
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 11 Apr 2023 11:12:37 +0200
Subject: [PATCH 1/1] OvmfPkg: call ReserveEmuVariableNvStore after
AmdSevInitialize
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
OvmfPkg/PlatformPei/Platform.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c
index c56247e294f2..1e70c1920830 100644
--- a/OvmfPkg/PlatformPei/Platform.c
+++ b/OvmfPkg/PlatformPei/Platform.c
@@ -378,10 +378,6 @@ InitializePlatform (
InitializeRamRegions (PlatformInfoHob);
if (PlatformInfoHob->BootMode != BOOT_ON_S3_RESUME) {
- if (!PlatformInfoHob->SmmSmramRequire) {
- ReserveEmuVariableNvStore ();
- }
-
PeiFvInitialization (PlatformInfoHob);
MemTypeInfoInitialization (PlatformInfoHob);
MemMapInitialization (PlatformInfoHob);
@@ -390,6 +386,12 @@ InitializePlatform (
InstallClearCacheCallback ();
AmdSevInitialize (PlatformInfoHob);
+
+ if ((PlatformInfoHob->BootMode != BOOT_ON_S3_RESUME) &&
+ (!PlatformInfoHob->SmmSmramRequire)) {
+ ReserveEmuVariableNvStore ();
+ }
+
if (PlatformInfoHob->HostBridgeDevId == 0xffff) {
MiscInitializationForMicrovm (PlatformInfoHob);
} else {
--
2.39.2
next prev parent reply other threads:[~2023-04-11 10:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 5:23 [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest Min Xu
2023-03-30 7:50 ` Gerd Hoffmann
2023-03-31 7:59 ` joeyli
2023-03-31 8:25 ` Gerd Hoffmann
2023-03-31 14:48 ` joeyli
2023-04-03 0:21 ` Min Xu
2023-04-03 11:20 ` Gerd Hoffmann
2023-04-06 1:42 ` Min Xu
2023-04-06 20:28 ` Lendacky, Thomas
2023-04-07 1:56 ` Min Xu
2023-04-07 14:49 ` [edk2-devel] " joeyli
2023-04-07 17:00 ` Lendacky, Thomas
2023-04-11 10:04 ` Gerd Hoffmann [this message]
2023-04-11 18:03 ` Lendacky, Thomas
2023-04-12 7:24 ` Gerd Hoffmann
2023-04-12 15:23 ` Lendacky, Thomas
2023-04-13 6:05 ` Gerd Hoffmann
2023-04-13 13:58 ` Lendacky, Thomas
2023-04-14 10:20 ` Gerd Hoffmann
2023-04-20 15:16 ` Lendacky, Thomas
2023-04-21 9:18 ` Gerd Hoffmann
2023-04-21 20:49 ` Lendacky, Thomas
2023-04-24 9:45 ` Gerd Hoffmann
2023-04-26 20:43 ` Lendacky, Thomas
2023-04-28 8:41 ` Gerd Hoffmann
2023-05-01 19:06 ` Lendacky, Thomas
2023-04-07 9:41 ` joeyli
2023-04-07 11:54 ` Min Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shlx36de2yoszmxy3wuapqsjek3uqtmg6xgqkw76ihstu2qysq@h5dabwczhcxk \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox