public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, marcin.juszkiewicz@linaro.org
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
	 Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Graeme Gregory <graeme@xora.org.uk>
Subject: Re: [edk2-devel] [PATCH edk2-platforms] SbsaQemu: move code outside of methods in DSDT
Date: Tue, 23 Apr 2024 12:00:02 +0200	[thread overview]
Message-ID: <skiniivk7ykeckyrnzfblul62ololp2rzmskimbyuh3xo5263f@peitbny4snlt> (raw)
In-Reply-To: <20240422085145.1234981-1-marcin.juszkiewicz@linaro.org>

  Hi,

> +        Name (RBUF, ResourceTemplate() {
> +            Memory32Fixed (ReadWrite,
> +                           FixedPcdGet32 (PcdPlatformXhciBase),
> +                           FixedPcdGet32 (PcdPlatformXhciSize))
> +            Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 43 }
> +        })
>          Method (_CRS, 0x0, Serialized) {
> -            Name (RBUF, ResourceTemplate() {

If the resources never change _CRS doesn't need to be a method, you can
go for "Name (_CRS, ResourceTemplate () ..." instead.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118134): https://edk2.groups.io/g/devel/message/118134
Mute This Topic: https://groups.io/mt/105666235/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2024-04-23 10:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22  8:51 [edk2-devel] [PATCH edk2-platforms] SbsaQemu: move code outside of methods in DSDT Marcin Juszkiewicz
2024-04-23 10:00 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=skiniivk7ykeckyrnzfblul62ololp2rzmskimbyuh3xo5263f@peitbny4snlt \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox