From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id DFCF4941451 for ; Tue, 23 Apr 2024 10:00:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Il1eWAsUQ86AL9/EGnUV1iFwZi0CQBbNaUv8wkjzCRw=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1713866415; v=1; b=BhBv/hfst7eJ9CDAVJGmqTrMPW/nXQpv7OC0INEYv727OT+lRZA45n9rIR0Z9XsaKGCFj4+e 7DJuZ7r4GjDWiHDVnFtyNF5sZJXimxOGf5eSda8eO8DqeW6huIoKLJ3+ECSjUnv0vh2dYdl5hEW 9ewFCmAB2Xv0ohvmhcftoRquefB/nw8K/5OFRjavmiaf3B7ypdETRzojqaoatu7i/kbpwBqWhzK dVEngIxjqHJG7K7/mFWjM4yifXWQ5deqZngWY7yUVnWlJjfhA7WhXNlOuszLFNxVC75bROWhXxl mUTobl+LOOi20+dqDC7onCz9TE90aIYZz6oWdJzIFiXGA== X-Received: by 127.0.0.2 with SMTP id 7IH0YY7687511xDrhFneuQ8Q; Tue, 23 Apr 2024 03:00:15 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.14793.1713866409658879411 for ; Tue, 23 Apr 2024 03:00:09 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-G_ypAbCXMsOuof1yNveU5w-1; Tue, 23 Apr 2024 06:00:04 -0400 X-MC-Unique: G_ypAbCXMsOuof1yNveU5w-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E7A73C1E9C2; Tue, 23 Apr 2024 10:00:03 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.150]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 631402166B36; Tue, 23 Apr 2024 10:00:03 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 351A91800DF0; Tue, 23 Apr 2024 12:00:02 +0200 (CEST) Date: Tue, 23 Apr 2024 12:00:02 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, marcin.juszkiewicz@linaro.org Cc: Leif Lindholm , Ard Biesheuvel , Graeme Gregory Subject: Re: [edk2-devel] [PATCH edk2-platforms] SbsaQemu: move code outside of methods in DSDT Message-ID: References: <20240422085145.1234981-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 In-Reply-To: <20240422085145.1234981-1-marcin.juszkiewicz@linaro.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 23 Apr 2024 03:00:09 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: GrWV55W2SSvBmnZSjcOjLFsMx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="BhBv/hfs"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > + Name (RBUF, ResourceTemplate() { > + Memory32Fixed (ReadWrite, > + FixedPcdGet32 (PcdPlatformXhciBase), > + FixedPcdGet32 (PcdPlatformXhciSize)) > + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 43 } > + }) > Method (_CRS, 0x0, Serialized) { > - Name (RBUF, ResourceTemplate() { If the resources never change _CRS doesn't need to be a method, you can go for "Name (_CRS, ResourceTemplate () ..." instead. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118134): https://edk2.groups.io/g/devel/message/118134 Mute This Topic: https://groups.io/mt/105666235/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-