public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Oliver Steffen <osteffen@redhat.com>
Cc: devel@edk2.groups.io, Anthony Perard <anthony.perard@citrix.com>,
	 Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	 Jordan Justen <jordan.l.justen@intel.com>,
	Julien Grall <julien@xen.org>,
	 Leif Lindholm <quic_llindhol@quicinc.com>,
	Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
	 Zhichao Gao <zhichao.gao@intel.com>
Subject: Re: [PATCH v4 0/2] Set Firmware Version from build command line
Date: Thu, 4 May 2023 12:13:03 +0200	[thread overview]
Message-ID: <sm2mxwagacfwdmqjrmfson2fhypbifltrmywdsq3wy4zhqtttm@5evbvueulows> (raw)
In-Reply-To: <20230414083323.153731-1-osteffen@redhat.com>

Ping.

On Fri, Apr 14, 2023 at 10:33:21AM +0200, Oliver Steffen wrote:
> ArmVirtXen.dsc allows setting the firmware version
> string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
> via FIRMWARE_VER variable conveniently on the build command line.
> 
> These two patches add this behavior to all .dsc files in ArmVirtPkg
> and OvmfPkg.
> 
> PR: https://github.com/tianocore/edk2/pull/4268
> 
> v4:
> - Actually use the include file
> 
> v3:
> - Introduce common include file for OVMF .dsc files
> https://edk2.groups.io/g/devel/message/102952
> 
> v2:
> Address comments by Sami and Gerd:
> - Only set PCD if FIRMWARE_VER is defined
> - ArmVirt: move logic to ArmVirt.dsc.inc
> https://edk2.groups.io/g/devel/message/95208
> 
> v1:
> https://edk2.groups.io/g/devel/message/95057
> 
> Oliver Steffen (2):
>   OvmfPkg: allow setting Firmware Version from build command line
>   ArmVirtPkg: allow setting Firmware Version from build command line
> 
>  ArmVirtPkg/ArmVirt.dsc.inc          | 4 ++++
>  OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 +++++++++
>  ArmVirtPkg/ArmVirtXen.dsc           | 1 -
>  OvmfPkg/OvmfPkgIa32.dsc             | 2 ++
>  OvmfPkg/OvmfPkgIa32X64.dsc          | 2 ++
>  OvmfPkg/OvmfPkgX64.dsc              | 3 +++
>  OvmfPkg/OvmfXen.dsc                 | 2 ++
>  7 files changed, 22 insertions(+), 1 deletion(-)
>  create mode 100644 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc
> 
> -- 
> 2.40.0
> 

-- 


  parent reply	other threads:[~2023-05-04 10:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14  8:33 [PATCH v4 0/2] Set Firmware Version from build command line Oliver Steffen
2023-04-14  8:33 ` [PATCH v4 1/2] OvmfPkg: allow setting " Oliver Steffen
2023-04-14  8:33 ` [PATCH v4 2/2] ArmVirtPkg: " Oliver Steffen
2023-04-14 12:13 ` [edk2-devel] [PATCH v4 0/2] Set " Rebecca Cran
2023-04-17 10:17   ` Gerd Hoffmann
2023-04-17 14:23     ` Rebecca Cran
2023-05-04 10:13 ` Gerd Hoffmann [this message]
2023-05-04 10:55   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sm2mxwagacfwdmqjrmfson2fhypbifltrmywdsq3wy4zhqtttm@5evbvueulows \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox