From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.46209.1683195188101106901 for ; Thu, 04 May 2023 03:13:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MW56mM98; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683195187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nwFpcQCrTLnWICyM0o26z6RpWG4GjgrWiDkkyHGBj/8=; b=MW56mM9807ECCj0vZCn2a2UqYAr8kMq0OQjS9FqW1DLSyMOmUd/apiNfumC/TE0vPX8huS R5RL/C+wEGCqZyK9M6gcX+fkVbMmua7IlgS0bCSDWlV7Rp2vwDl5H8qGVhcZTZSxeh0rDp os8SddIvBOF4Mof2IUXzMZif3mk3jPY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-jP5nm2YKP9qxDmLNS04UrQ-1; Thu, 04 May 2023 06:13:06 -0400 X-MC-Unique: jP5nm2YKP9qxDmLNS04UrQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9AB681C05AE1; Thu, 4 May 2023 10:13:05 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 64AC6C15BAE; Thu, 4 May 2023 10:13:05 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0474C1800922; Thu, 4 May 2023 12:13:04 +0200 (CEST) Date: Thu, 4 May 2023 12:13:03 +0200 From: "Gerd Hoffmann" To: Oliver Steffen Cc: devel@edk2.groups.io, Anthony Perard , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Ray Ni , Sami Mujawar , Zhichao Gao Subject: Re: [PATCH v4 0/2] Set Firmware Version from build command line Message-ID: References: <20230414083323.153731-1-osteffen@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230414083323.153731-1-osteffen@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Ping. On Fri, Apr 14, 2023 at 10:33:21AM +0200, Oliver Steffen wrote: > ArmVirtXen.dsc allows setting the firmware version > string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > via FIRMWARE_VER variable conveniently on the build command line. > > These two patches add this behavior to all .dsc files in ArmVirtPkg > and OvmfPkg. > > PR: https://github.com/tianocore/edk2/pull/4268 > > v4: > - Actually use the include file > > v3: > - Introduce common include file for OVMF .dsc files > https://edk2.groups.io/g/devel/message/102952 > > v2: > Address comments by Sami and Gerd: > - Only set PCD if FIRMWARE_VER is defined > - ArmVirt: move logic to ArmVirt.dsc.inc > https://edk2.groups.io/g/devel/message/95208 > > v1: > https://edk2.groups.io/g/devel/message/95057 > > Oliver Steffen (2): > OvmfPkg: allow setting Firmware Version from build command line > ArmVirtPkg: allow setting Firmware Version from build command line > > ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++ > OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 +++++++++ > ArmVirtPkg/ArmVirtXen.dsc | 1 - > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > OvmfPkg/OvmfPkgX64.dsc | 3 +++ > OvmfPkg/OvmfXen.dsc | 2 ++ > 7 files changed, 22 insertions(+), 1 deletion(-) > create mode 100644 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc > > -- > 2.40.0 > --